This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Add support for Query type, add tests and filter out fields with argu… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed an issue @kitten mentioned which is use of directives which contain variables. We now have variable support - it's a matter of deciding whether we want to do take this route (I'm hearing good reasons both for and against) |
JoviDeCroock
approved these changes
Dec 14, 2019
kitten
reviewed
Dec 14, 2019
| }, | ||
| FragmentDefinition: node => { | ||
| extractedFragments.push(node); | ||
| leave: extractedFragments.push(node); |
There was a problem hiding this comment.
This isn’t an object so leave here is actually a label 😅 seems like this change can be reverted 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Fix #123
Changes
Todo