Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy deprecation warning with 0.12.28 #1311

Closed
palfrey opened this issue Sep 30, 2024 · 6 comments
Closed

SQLAlchemy deprecation warning with 0.12.28 #1311

palfrey opened this issue Sep 30, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@palfrey
Copy link

palfrey commented Sep 30, 2024

Weren't seeing this with 0.12.27, only 0.12.28
sqlalchemy.exc.SADeprecationWarning: The SelectBase.c and SelectBase.columns attributes are deprecated and will be removed in a future release; these attributes implicitly create a subquery that should be explicit. Please call SelectBase.subquery() first in order to create a subquery, which then contains this attribute. To access the columns that this SELECT object SELECTs from, use the SelectBase.selected_columns attribute. (deprecated since: 1.4)

I suspect this is due to https://github.com/uriyyo/fastapi-pagination/blob/main/fastapi_pagination/ext/sqlalchemy.py#L79 / #1281

@palfrey
Copy link
Author

palfrey commented Sep 30, 2024

For anyone else hitting this, adding "ignore::sqlalchemy.exc.SADeprecationWarning:fastapi_pagination.ext.sqlalchemy:79", to your pyproject.toml ignores solves this for the moment.

@alex-goswag
Copy link

Also seeing the same

requirements.txt

fastapi[all]==0.115.0
sqlalchemy==2.0.32
fastapi-pagination==0.12.28

@uriyyo uriyyo self-assigned this Sep 30, 2024
@uriyyo uriyyo added the bug Something isn't working label Sep 30, 2024
@uriyyo
Copy link
Owner

uriyyo commented Oct 1, 2024

Hi @alex-goswag @palfrey,

New version 0.12.29 has been released. Could you please check if issue still exists on your side?

@palfrey
Copy link
Author

palfrey commented Oct 1, 2024

Hi @alex-goswag @palfrey,

New version 0.12.29 has been released. Could you please check if issue still exists on your side?

No longer seeing the issue with 0.12.29

@palfrey palfrey closed this as completed Oct 1, 2024
@uriyyo
Copy link
Owner

uriyyo commented Oct 1, 2024

Great, thanks for fast response!

@palfrey
Copy link
Author

palfrey commented Oct 2, 2024

Thanks for the fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants