Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v9+ support #1

Open
alexcastillo opened this issue Sep 26, 2018 · 7 comments
Open

Node v9+ support #1

alexcastillo opened this issue Sep 26, 2018 · 7 comments

Comments

@alexcastillo
Copy link

alexcastillo commented Sep 26, 2018

Hey Uri!

It seems node-lsl does not support node v9+ because of its ffi dependency. It looks they last published a new version 2 years ago.

I was looking into other alternatives for node bindings and found:
https://www.npmjs.com/package/fastcall

Dano mentioned N-API and WASM.

What are your thoughts?

@jdpigeon
Copy link
Contributor

I'm doing a bunch of work on my fork: https://github.com/makebrainwaves/node-lsl

Since fastcall is supposed to be a drop-in replacement for node-ffi I can play around with adding that and, if it works, merge those changes back to this repo.

BTW guys, I think we can make this the official liblsl Node wrapper eventually 🔥

@alexcastillo
Copy link
Author

Sounds like a plan, go Dano!

@urish
Copy link
Owner

urish commented Sep 27, 2018

Awesome!

@CalvinLeather
Copy link

Ended up going the n-api route for ffi and ref, have the results on a fork here: working on node v12 https://github.com/CalvinLeather/node-lsl if anyone wants to use before I clean up and possible PR into this repo.

Is this repo open for PRs? I've been using this repo on a couple projects, wouldn't mind maintaining a bit while I use it.

@urish
Copy link
Owner

urish commented Feb 11, 2020

@CalvinLeather yes, I can add you as a collaborator if you are open to maintaining it

@CalvinLeather
Copy link

Sounds good, yeah I will be working with it for the next year or so at least. I'll PR in a bit. Thanks!

@oori
Copy link

oori commented Mar 2, 2020

@CalvinLeather any plan to push your PR ? would be nice to have this update on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants