Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling if there is no template defined in the project #68

Open
kflemin opened this issue Aug 14, 2020 · 2 comments
Open

Add error handling if there is no template defined in the project #68

kflemin opened this issue Aug 14, 2020 · 2 comments

Comments

@kflemin
Copy link
Contributor

kflemin commented Aug 14, 2020

this will create obscure errors especially for mixed use buildings...
add a warning that template is not defined, or default it to ashrae. (lookup_building_type is the function to update)

@laurenklun
Copy link

@kflemin I was going to add this issue to the new board but I don't have access to edit.

You should be able to select "9/30/20 SDK Release" in the Projects header on the right sidebar of this page. It then usually goes into triage on that board I think and you just have to move it into one of the columns

@vtnate
Copy link
Collaborator

vtnate commented Jan 22, 2025

@kflemin I think the solution is to replace this raise: https://github.com/urbanopt/urbanopt-example-geojson-project/blob/os39/example_project/mappers/Baseline.rb#L745. However, this later section may also need to be adjusted in that case.

Should we go so far as to change the geojson file, or do it all within memory? Does doing it in memory hide our actions, or does it not matter since the geojson file will always take precedence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants