Add horizontal pipe pressure drop to sys-params #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
changed the title
|
@nllong Unrelated to this PR, the district_single_ghe.py simulation test fails on CI but passes locally for me. It is the only failing test, preventing green here on github. Can you help me figure out what is different about the CI runner, possibly just for that test? |
nllong
approved these changes
Feb 13, 2025
geojson_modelica_translator/model_connectors/networks/templates/DesignDataSeries.mot
Show resolved
Hide resolved
geojson_modelica_translator/system_parameters/system_parameter_properties.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicholas Long <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The horizontal pipe pressure drop had been hard-coded into a number of Modelica templates throughout the GMT. Exposing it as a user-adjustable variable in the sys-param file will enable more control over the model, as well as allowing ThermalNetwork to use the same value.
What does this PR accomplish?
How should this be manually tested?
CI is sufficient
What are the relevant tickets?
Resolves #696