From 7441ecf864c2c21d1fd65cc4e8cebd696ceece0b Mon Sep 17 00:00:00 2001 From: Ryan Lepinski Date: Wed, 9 Oct 2024 10:00:43 -0700 Subject: [PATCH 1/3] Add old arch CI --- .github/workflows/ci.yml | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a46c5e5..82f55063 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: [pull_request] jobs: test: - runs-on: macos-13-xlarge + runs-on: macos-14-xlarge steps: - uses: actions/checkout@v4 - name: Set up JDK 17 @@ -33,3 +33,37 @@ jobs: - run: npm run bootstrap - run: bash ./scripts/run_ci_tasks.sh -i - run: bash ./scripts/run_ci_tasks.sh -a + + test-android-old-arch: + runs-on: macos-14-xlarge + steps: + - uses: actions/checkout@v4 + - name: Set up JDK 17 + uses: actions/setup-java@v3 + with: + distribution: 'temurin' + java-version: '17' + + - name: Set up Ruby + uses: ruby/setup-ruby@v1 + with: + ruby-version: '3.0.1' + + - name: Install CocoaPods + run: gem install cocoapods -v '1.15.2' + + - name: Select Xcode version + run: sudo xcode-select -s '/Applications/Xcode_15.2.app/Contents/Developer' + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + node-version-file: .nvmrc + cache: 'npm' + + - run: | + sed -i '' 's/newArchEnabled=true/newArchEnabled=false/' example/android/gradle.properties + npm run bootstrap + run: bash ./scripts/run_ci_tasks.sh -a + + From a9b8f2857225454f9256e80a7b4b21ceb0ed7d45 Mon Sep 17 00:00:00 2001 From: Ryan Lepinski Date: Wed, 9 Oct 2024 10:06:51 -0700 Subject: [PATCH 2/3] Fix --- .github/workflows/ci.yml | 7 +++---- example/android/gradle.properties | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 82f55063..a1934a72 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,9 +61,8 @@ jobs: node-version-file: .nvmrc cache: 'npm' - - run: | - sed -i '' 's/newArchEnabled=true/newArchEnabled=false/' example/android/gradle.properties - npm run bootstrap - run: bash ./scripts/run_ci_tasks.sh -a + - run: sed -i '' 's/newArchEnabled=true/newArchEnabled=false/' example/android/gradle.properties + - run: npm run bootstrap + - run: bash ./scripts/run_ci_tasks.sh -a diff --git a/example/android/gradle.properties b/example/android/gradle.properties index 2cc63729..2f117e04 100644 --- a/example/android/gradle.properties +++ b/example/android/gradle.properties @@ -34,7 +34,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64 # your application. You should enable this flag either if you want # to write custom TurboModules/Fabric components OR use libraries that # are providing them. -newArchEnabled=true +newArchEnabled=false # Use this property to enable or disable the Hermes JS engine. # If set to false, you will be using JSC instead. From cf0d2195c3ae1da87b1ac1a725486be63804b321 Mon Sep 17 00:00:00 2001 From: Ryan Lepinski Date: Wed, 9 Oct 2024 10:09:25 -0700 Subject: [PATCH 3/3] Fix --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a1934a72..53a25077 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: [pull_request] jobs: test: - runs-on: macos-14-xlarge + runs-on: macos-13-xlarge steps: - uses: actions/checkout@v4 - name: Set up JDK 17 @@ -35,7 +35,7 @@ jobs: - run: bash ./scripts/run_ci_tasks.sh -a test-android-old-arch: - runs-on: macos-14-xlarge + runs-on: macos-13-xlarge steps: - uses: actions/checkout@v4 - name: Set up JDK 17