Skip to content
This repository has been archived by the owner on Nov 28, 2019. It is now read-only.

Remove Locking Logic from Server #5

Closed
ngparas opened this issue Jul 9, 2018 · 3 comments
Closed

Remove Locking Logic from Server #5

ngparas opened this issue Jul 9, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@ngparas
Copy link
Contributor

ngparas commented Jul 9, 2018

Locking logic is currently implemented in server.py. We should consider pushing this logic into the storage instead of the server itself. For example, suppose we used something like sqlite or redis to handle the package metadata instead of writing to the PACKAGES file directly. We would prefer those handle locking over doing it ourselves, and it would allow multiple instances of the server container to run concurrently.

This issue addresses the TODO left in the code here:
https://github.com/UptakeOpenSource/cran-server/blob/master/cran-server/server.py#L102

@ngparas ngparas added the enhancement New feature or request label Jul 9, 2018
@ngparas
Copy link
Contributor Author

ngparas commented Jul 9, 2018

This is related to #8

@ntdef
Copy link
Collaborator

ntdef commented Sep 6, 2018

Oh hey I fixed this in PR #25

@ntdef
Copy link
Collaborator

ntdef commented Sep 6, 2018

Resolved.

@ntdef ntdef closed this as completed Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants