[chore]: upgrade compare-versions
to 6.0.0
#48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
compare-versions
to6.0.0
because this version supports parsing "malformed" version ranges.It still has the same limitations our solution did -- it will still return
"invalid"
for ranges like1. 0 . 0
because the RegEx for matching unintentional spaces between numbers (and ignoring intentional spaces) is super complex. i don't think evennpm
'ssemver
package fully supports this -- i believe they just have a bunch of logic to figure out a "best guess".CHANGES
compare-versions
to6.0.0
TESTING
You can update the new test at the bottom of
get-package-data.spec.ts
for different variations of unintentional white space. it should support:> =
)>= 10
)||
operator and numbers (8 || 9
)