Skip to content

Commit fd2b2f4

Browse files
committed
some code cleanup
1 parent d67e7b4 commit fd2b2f4

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

addon/components/o-s-s/phone-number-input.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
@searchPlaceholder="Search"
4646
id={{this.portalId}}
4747
class={{concat "margin-top-px-0 phone-number-container__dropdown " this.dropdownAddressableClass}}
48-
{{on-click-outside this.hideCountrySelector}}
48+
{{on-click-outside this.onClickOutside}}
4949
{{on "click" this.noop}}
5050
>
5151
<:option as |country|>

addon/components/o-s-s/phone-number-input.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,6 @@ export default class OSSPhoneNumberInput extends BaseDropdown<OSSPhoneNumberInpu
142142
}
143143
}
144144

145-
@action
146-
hideCountrySelector(): void {
147-
this.filteredCountries = this._countries;
148-
this.closeDropdown();
149-
this.cleanupDrodpownAutoplacement?.();
150-
document.querySelector(`#${this.portalId}`)?.remove();
151-
}
152-
153145
@action
154146
focusInput(): void {
155147
this.inputElement?.focus();
@@ -165,6 +157,13 @@ export default class OSSPhoneNumberInput extends BaseDropdown<OSSPhoneNumberInpu
165157
this.hideCountrySelector();
166158
}
167159

160+
private hideCountrySelector(): void {
161+
this.filteredCountries = this._countries;
162+
this.closeDropdown();
163+
this.cleanupDrodpownAutoplacement?.();
164+
document.querySelector(`#${this.portalId}`)?.remove();
165+
}
166+
168167
private validateInput(): void {
169168
this.invalidInputError = '';
170169

0 commit comments

Comments
 (0)