You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice to further increase test coverage. To do so I think we have to run tests against a real kafka server. There's some work in progress to implement this: https://github.com/idealo/Kafka-Librd/blob/more-testing-with-broker/t/fulltest.t
This test script starts zookeeper and kafka on the fly with temporary directories and ports, and runs some Kafka::Librd commands on this.
However a lot of polishing is still needed:
probably this test script should only run in some environments (e.g. in some travis-ci configurations, and if the user explicitly requests it)
kafka should be made available, either downloaded by the test script or outside using .travis.yml
zookeeper should be made available, either downloaded by the test script or outside using .travis.yml; installation could also be done via package manager at least on debian-based systems
there are some sleep() calls in the test script which should be removed
more test cases have to be written
The text was updated successfully, but these errors were encountered:
Thanks for opening this, I was thinking along these lines as well.
It would be nice (esp. for CI, but also for local dev) to be able to test against a kafka docker instance to avoid the dependencies on zookeeper etc. I did some minimal poking around on dockerhub and didn't find anything that looked well supported or recent though.
Agree that live testing against real kafka server should happen in CI plus with an appropriate Kafka::Librd specific environment variable for developers. Obviously don't want to be clever and detect an instance that turns out to be a server handling production traffic.
It would be nice to further increase test coverage. To do so I think we have to run tests against a real kafka server. There's some work in progress to implement this: https://github.com/idealo/Kafka-Librd/blob/more-testing-with-broker/t/fulltest.t
This test script starts zookeeper and kafka on the fly with temporary directories and ports, and runs some Kafka::Librd commands on this.
However a lot of polishing is still needed:
The text was updated successfully, but these errors were encountered: