Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation on --sprite functionality in documentation #115

Open
pnorman opened this issue Nov 2, 2022 · 3 comments
Open

No documentation on --sprite functionality in documentation #115

pnorman opened this issue Nov 2, 2022 · 3 comments

Comments

@pnorman
Copy link

pnorman commented Nov 2, 2022

Describe the bug

charites build --help has three parameters related to sprites, --sprite-url, --sprite-input, --sprite-output which hint that there's icon building functionality with charites.

There is nothing in the documentation about how to use this functionality

Expected behavior
How to build sprites with charites is documented

Charites Version:

  • Charites version: 0.1.4
@champierre
Copy link
Contributor

@pnorman There is an explanation of these options in https://unvt.github.io/charites/usage/commandline_interface.html, and a sample of usage in https://unvt.github.io/charites/usage/examples.html.
I know the current documentation is not enough yet, so could you clarify what information you want to know more about?

@pnorman
Copy link
Author

pnorman commented Dec 1, 2022

-i and -o imply that charites can build sprites, but I can't figure out how this works. Where do the spritesheets get saved. How can we use serve with sprites built from charites?

@keichan34
Copy link
Contributor

I agree that this feature needs more documentation.

The current way this works now is you pass a directory to -i, that is full of SVG files you want to be compiled to a sprite sheet. You can use maki icons if you like, but any SVG file should work (only SVG is supported now -- I want to add PNG support as well in the future: unvt/sprite-one#17). The generated spritesheets ( [name].png/json and [name]@2x.png/json ) are output in the directory specified by -o. However, the way [name] is calculated from the sprite field of the input yml file is not documented.

I think this should probably be documented using its own page, in addition with an update to build example

Additionally, sprites doesn't work with serve right now, I've added an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants