Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nominator_name - nominator_institution string a property of Nominator #39

Open
ldko opened this issue Feb 22, 2016 · 0 comments
Open

Make nominator_name - nominator_institution string a property of Nominator #39

ldko opened this issue Feb 22, 2016 · 0 comments
Assignees
@madhuBayy

Comments

@ldko
Copy link
Member

ldko commented Feb 22, 2016 •
edited
Loading

In multiple places we are joining a Nominator instance's name and institution values with a ' - '. We may want to move this string generation into the Nominator model as an attribute/property. See:

django-nomination/nomination/url_handler.py

Line 518 in 0bf5740

if url_object.url_nominator.nominator_name + ' - ' + \

django-nomination/nomination/url_handler.py

Line 574 in 0bf5740

nominator = url_object.url_nominator.nominator_name + ' - ' + \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhuBayy madhuBayy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ldko @madhuBayy