Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS 17] Fluent Button text is offset to the right #13331

Closed
jeromelaban opened this issue Aug 21, 2023 · 9 comments
Closed

[iOS 17] Fluent Button text is offset to the right #13331

jeromelaban opened this issue Aug 21, 2023 · 9 comments
Assignees
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/bug Something isn't working platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@jeromelaban
Copy link
Member

jeromelaban commented Aug 21, 2023

Current behavior

Location of the code below.

iOS 16:
20230821_141402000_iOS

iOS 17:
20230821_141348000_iOS

How to reproduce it (as minimally and precisely as possible)

Uno Gallery running in iOS 17 Preview 5

Workaround

None so far

Environment

No response

NuGet package version(s)

4.9.43
5.0.0-dev.2127

Anything else we need to know?

Clicking the button makes the text appear at the appropriate location.

@jeromelaban jeromelaban added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 21, 2023
@jeromelaban jeromelaban changed the title [iOS 17 Beta 5] Fluent Button [iOS 17 Beta 5] Fluent Button text is offset to the right Aug 21, 2023
@jeromelaban jeromelaban added platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform and removed triage/untriaged Indicates an issue requires triaging or verification labels Aug 21, 2023
@jeromelaban
Copy link
Member Author

Update: iOS 17 Beta 6 does not fix this issue.

@jeromelaban jeromelaban changed the title [iOS 17 Beta 5] Fluent Button text is offset to the right [iOS 17] Fluent Button text is offset to the right Aug 21, 2023
@jeanplevesque
Copy link
Member

Do you know what's special about this style that causes the issue? Like why it happens on that particular style but not on others?

@jeromelaban
Copy link
Member Author

The button in the screenshot is this one:

<Style x:Key="DefaultButtonStyle" TargetType="Button">

But we do not yet have more details to provide.

@jeromelaban
Copy link
Member Author

jeromelaban commented Aug 31, 2023

Update on this, iOS 17 Beta 8:
@ajpinedam tested on an iPhone 14 Pro, the issue does not repro
On mine, iPhone Xs the issue reproduces
On an iPhone 13 Pro, the issue does not repro
On an iPhone Xs Simulator, the issue does not repro

Continuing the investigation.

@ajpinedam
Copy link
Contributor

Update:

We noticed the issue is happening when having a TextBlock as the Root Content of a Button, something like this:

  <Button Click="GetGeopositionButton_Click">
      <TextBlock Text="{Binding ButtonContent}" VerticalAlignment="Stretch" TextAlignment="Center" />
  </Button>

On Gallery, on the Sample Page we are seeing this problem, we have replaced the code above (PR # unoplatform/Uno.Gallery#941) with a simple Button:

  <Button Click="GetGeopositionButton_Click"
		Content="{Binding ButtonContent}"
		HorizontalContentAlignment="Center"
		VerticalContentAlignment="Stretch" />

Once merged we will test on the device where the problem was reported.

@MartinZikmund MartinZikmund added difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 23, 2023
@MartinZikmund
Copy link
Member

@ajpinedam is this issue fixed now?

@jeromelaban
Copy link
Member Author

It's not, but we've not been able to reliably reproduce it at this time.

@ajpinedam
Copy link
Contributor

@jeromelaban this issue seems to be fixed in later versions of iOS. Can we close this issue?

@jeromelaban
Copy link
Member Author

Yes, let's close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/bug Something isn't working platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Development

No branches or pull requests

4 participants