From 4fe5eca982e57a37a2702c38ce15cd15a5d44a2e Mon Sep 17 00:00:00 2001
From: Andres Pineda <pineda.andres@gmail.com>
Date: Thu, 9 Jan 2025 00:08:56 -0500
Subject: [PATCH] feat: add a couple of UpdateItemAsync overloads

---
 .../Core/ListState.Extensions.cs              | 60 ++++++++++++++++++-
 1 file changed, 57 insertions(+), 3 deletions(-)

diff --git a/src/Uno.Extensions.Reactive/Core/ListState.Extensions.cs b/src/Uno.Extensions.Reactive/Core/ListState.Extensions.cs
index 61ef8b1af..04bea8016 100644
--- a/src/Uno.Extensions.Reactive/Core/ListState.Extensions.cs
+++ b/src/Uno.Extensions.Reactive/Core/ListState.Extensions.cs
@@ -123,7 +123,6 @@ public static ValueTask RemoveAllAsync<T>(this IListState<T> state, Predicate<T>
 		=> state.UpdateDataAsync(itemsOpt => itemsOpt.Map(items => items.RemoveAll(match)), ct);
 
 
-
 	/// <summary>
 	/// Updates all items from a list state that match the key of <paramref name="oldItem"/>.
 	/// </summary>
@@ -133,7 +132,8 @@ public static ValueTask RemoveAllAsync<T>(this IListState<T> state, Predicate<T>
 	/// <param name="newItem">The new value for the item.</param>
 	/// <param name="ct">A token to abort the async add operation.</param>
 	/// <returns></returns>
-	public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem,  T newItem, CancellationToken ct = default) where T : IKeyEquatable<T>
+	public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem, T newItem, CancellationToken ct = default)
+		where T : notnull, IKeyEquatable<T>
 		=> state.UpdateDataAsync(
 			itemsOpt => itemsOpt.Map(items =>
 			{
@@ -150,6 +150,33 @@ public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem,
 			ct);
 
 
+	/// <summary>
+	/// Updates all items from a list state that match the key of <paramref name="oldItem"/>.
+	/// </summary>
+	/// <typeparam name="T">The type of the items in the list.</typeparam>
+	/// <param name="state">The list state onto which the item should be added.</param>
+	/// <param name="oldItem">The old value of the item.</param>
+	/// <param name="newItem">The new value for the item.</param>
+	/// <param name="ct">A token to abort the async add operation.</param>
+	/// <returns></returns>
+	public static ValueTask UpdateItemAsync<T>(this IListState<T?> state, T oldItem, T? newItem, CancellationToken ct = default)
+		where T : struct, IKeyEquatable<T>
+		=> state.UpdateDataAsync(
+			itemsOpt => itemsOpt.Map(items =>
+			{
+				var updated = items;
+				foreach (var item in items)
+				{
+					if (item?.KeyEquals(oldItem) == true)
+					{
+						updated = items.Replace(item, newItem);
+					}
+				}
+				return updated;
+			}),
+			ct);
+
+
 	/// <summary>
 	/// Updates all items from a list state that match the key of <paramref name="oldItem"/>.
 	/// </summary>
@@ -159,7 +186,8 @@ public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem,
 	/// <param name="updater">How to update items.</param>
 	/// <param name="ct">A token to abort the async add operation.</param>
 	/// <returns></returns>
-	public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem, Func<T, T> updater, CancellationToken ct = default) where T : IKeyEquatable<T>
+	public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem, Func<T, T> updater, CancellationToken ct = default)
+		where T : notnull, IKeyEquatable<T>
 		=> state.UpdateDataAsync(
 			itemsOpt => itemsOpt.Map(items =>
 			{
@@ -175,6 +203,32 @@ public static ValueTask UpdateItemAsync<T>(this IListState<T> state, T oldItem,
 			}),
 			ct);
 
+	/// <summary>
+	/// Updates all items from a list state that match the key of <paramref name="oldItem"/>.
+	/// </summary>
+	/// <typeparam name="T">The type of the items in the list.</typeparam>
+	/// <param name="state">The list state onto which the item should be added.</param>
+	/// <param name="oldItem">The old value of the item.</param>
+	/// <param name="updater">How to update items.</param>
+	/// <param name="ct">A token to abort the async add operation.</param>
+	/// <returns></returns>
+	public static ValueTask UpdateItemAsync<T>(this IListState<T?> state, T oldItem, Func<T?, T?> updater, CancellationToken ct = default)
+		where T : struct, IKeyEquatable<T>
+		=> state.UpdateDataAsync(
+			itemsOpt => itemsOpt.Map(items =>
+			{
+				var updated = items;
+				foreach (var item in items)
+				{
+					if (item?.KeyEquals(oldItem) == true)
+					{
+						updated = items.Replace(item, updater(item));
+					}
+				}
+				return updated;
+			}),
+			ct);
+
 
 	/// <summary>
 	/// Updates all matching items from a list state.