Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated and Duplicated Material Pages #1514

Open
DevTKSS opened this issue Jan 4, 2025 · 2 comments
Open

Outdated and Duplicated Material Pages #1514

DevTKSS opened this issue Jan 4, 2025 · 2 comments
Labels
kind/documentation Improvements or additions to documentation

Comments

@DevTKSS
Copy link

DevTKSS commented Jan 4, 2025

On which page?

Uno public available (html) Documentation enterable from Themes/Overview/Material:
Themes Namespace material-getting-started
since Themes Namespace material-migration is having same/similar namespaces, consider checking them also

What's wrong?

(Themes Docs Pages)
Currenty it's told to use the Uno.Material set like this:
image

and this for dsp usage:
image

But from wizard created using Material theme the currently created single head uno project app.xaml is including this:
image

I tryed doing as told there (uno.sdk 5.5.56) and with this in place the app is not building any longer because the resources could not be resolved and resulted in 'Exception_WasThrown' in the Programm.cs builder method on Desktop target
resetting it to the namspaces showed in last screenshot is getting no issue, only not showing any ResourceKeys to any Material style/theme and also not the one defined in the dsp!

Any feedback?

Duplicated Page?
Uno public available Documentation enterable from Toolkit/Overview/Material:
https://github.com/unoplatform/uno.toolkit.ui/blob/main/doc/material-getting-started.md/#L1
seems to be more correct (newer Version?) but also not representing what we get in the currently wizard generated single head projects
at least from my point this could work because correct Namespaces

this Note on the Toolkit section version made me (using xaml not c#) think about "am I missing a AppBuilder Extension Method? because in my wizard created app.xaml.cs file is none of this Methods. Only one including something with Toolkit is the .UseToolkitNavigation() for the Navigator
image
if you are editing maybe, could you add a bit text to tell also for the xaml users if that extension method have to be used or not? currently its not set up by default but seems to work beside that missing ResourceKeys in intellisence at designtime.

@DevTKSS DevTKSS added the kind/documentation Improvements or additions to documentation label Jan 4, 2025
@kazo0
Copy link
Collaborator

kazo0 commented Jan 7, 2025

Hello @DevTKSS!

Thanks for the report! So there is actually a valid case for both of these scenarios.

The usage of <MaterialTheme xmlns="using:Uno.Material" /> is valid when you are only using the Uno.Material.WinUI NuGet package and not Uno.Toolkit.WinUI.Material

Otherwise, if you are using the Uno.Toolkit.WinUI.Material library, you can initialize the Toolkit AND Material resources in a single line with <MaterialToolkitTheme xmlns="using:Uno.Toolkit.UI.Material" />

Let me know if that clears things up or if there are other questions that I may not have covered!

@DevTKSS
Copy link
Author

DevTKSS commented Jan 7, 2025

Honestly? No, not really... These both pages in documentation are looking almost the same and the difference if there is one, is not getting clear of any of them, sorry...
The fact to not be able to use both or just the statement of "Do not try to use that one if you have already opted to material and/or dsp" is from my point of view missing at all.
Since My Project is currently using material and has the xaml of Coloroverrides file (do I remember that wrong or shouldn't there be opt1 none or opt2 xaml+json in that folder😅🤔) thats strange... To me there was no idea of there even existing two different things and whats the difference on this.
What I did understand was, we have that two themes (beside ios and cupertino which I will never use as win user) the material and the fluent one. Everytime I am searching for something in the docs, which is not nested in the extensions like navigation c# and mvux, its like random search and hoping the searchbar is spilling out what I am searching for. Topics like x:Bind are really (really!) hard to understand from what's not told for c# markup which is making it look like no problem at all🫣 in xaml and trying to work with mvux is... Not working most of the time, so performance section nice joke😬

Just if I would try to logical search for things like material and other theme related stuff, that would first be something named "Themes"

If I would then search for things like control extensions and other enhancements not directly related to the theme thing, that would be something like toolkit.

BUT there is that point "Wait, the controlextensions are using themes like the elevation and adding commands (if I overflowed that correctly yesterday) so they are something in-between..."
But lets say the reader is a really newbe on uno, I would not estimate of that person to know, what might be the difference of that themes in that uno.themes namespace and the uno.toolkit namespace.

And just as fun fact by the way:
Its not improving understandment if there is a namespace called Uno.Toolkit.UI and also one called Uno.UI.Toolkit
Maybe for creators that might be logical, but without deep diving into Repositorys, I dont think I would ever get it in my head what to search in one or the other namespace.

But that's only my own opinion, that does not mean everyone else has to agree with that!
Just wanted to point out with this, what a beginner is seeing when looking at this.
To leave a good thing mentioned:
Compared from my start at around November and the change made along the HotDesign documentation was added and the docs are generally restructured, the structure has been really improved, from getting started to the Reference. Just that ones below are currently at state of "could be better" in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants