Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up canWrapper.cc #7

Closed
garrettsummerfi3ld opened this issue Jul 8, 2024 · 0 comments · Fixed by #8
Closed

Clean up canWrapper.cc #7

garrettsummerfi3ld opened this issue Jul 8, 2024 · 0 comments · Fixed by #8
Assignees
@garrettsummerfi3ld

Comments

@garrettsummerfi3ld
Copy link
Member

garrettsummerfi3ld commented Jul 8, 2024 •
edited
Loading

From upstream:

There are a lot of strange changes in this file, mostly made in commit b0ca096 that doesn't explain why they were made. When you are making big changes like that, please explain your reasoning in the commit message, and don't include changes that are unrelated to the purpose of that commit.
Looking at it more, I see that the strange changes are actually just you accidentally undoing all of the changes made to this file in 2024.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettsummerfi3ld garrettsummerfi3ld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert changes made to canWrapper.cc unofficial-rev-port/node-can-bridge
1 participant
@garrettsummerfi3ld