Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🕹️] API Name is cached after renaming #2193

Open
3 tasks done
Flo4604 opened this issue Oct 4, 2024 · 10 comments · May be fixed by #2215
Open
3 tasks done

[🕹️] API Name is cached after renaming #2193

Flo4604 opened this issue Oct 4, 2024 · 10 comments · May be fixed by #2215

Comments

@Flo4604
Copy link
Contributor

Flo4604 commented Oct 4, 2024

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Sometimes when you rename your api the old name will stayed cached in the header

Steps to Reproduce

  1. Go into an api
  2. Rename it
  3. See if the name is correct, sometimes this only happens after a second rename ( See repro video on prod )

Expected behavior

That the name always changes once I press save

Other information

No response

Screenshots

caching.mp4

Version info

-
@Flo4604 Flo4604 added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 4, 2024
Copy link

linear bot commented Oct 4, 2024

@AkshayBandi027
Copy link
Contributor

AkshayBandi027 commented Oct 5, 2024

When using unstable_cache in Breadcrum to cache API calls, changes to properties are not triggering cache revalidation. Specifically, updating a property does not invalidate the cached response, resulting in stale data being returned.

Not only in api renaming but also -

  • API renaming
  • Rate limiting namespace updates
  • Authorization role updates ( changing role names)
  • Authorization permission updates (changing permission names

To address this, we can revalidateTag to revalidate the cache when properties change.

one of solutions -
https://github.com/user-attachments/assets/a5b08387-9628-44de-82b3-443588256f69

I have working solution but waiting for maintainers to add oss.gg label

@DeepaPrasanna
Copy link
Contributor

Hey @AkshayBandi027 You should first assign yourself and then start working on it. But before that, pls wait for the maintainers to add oss.gg label and points

@chronark
Copy link
Collaborator

chronark commented Oct 5, 2024

@AkshayBandi027 Yes, I was about to suggest tags as well, can you do them all?

@chronark
Copy link
Collaborator

chronark commented Oct 5, 2024

/award 150 points

Copy link

oss-gg bot commented Oct 5, 2024

Awarding Flo4604: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Flo4604

@AkshayBandi027
Copy link
Contributor

AkshayBandi027 commented Oct 5, 2024

/assign

@AkshayBandi027 AkshayBandi027 linked a pull request Oct 5, 2024 that will close this issue
17 tasks
@Harsh-Sanklecha
Copy link

/assign

Copy link

oss-gg bot commented Oct 7, 2024

Assigned to @Harsh-Sanklecha! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@chronark
Copy link
Collaborator

chronark commented Oct 7, 2024

@Harsh-Sanklecha hold on please, there's already a PR for this
I'm trying to understand why the bot allowed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants