You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
kraft uses the name field from kraft.yaml to retrieve the kernel binary file to conduct the build/run tasks. But if users use make menuconfig to configure the app, the default binary name would be the directory name. Such mixing up may lead to the following two confusions if the name field of kraft.yaml does not match the directory name:
kraft build: if the configuration is correct, the build process will succeed, but nothing will be outputted after Successfully built unikernels:, which is weird.
kraft run: kraft will not retrieve any binary file. Thus, it will output an error message [CRITICAL] list index out of range
After discussing with the community, two acceptable solutions are raised:
Use a better error message (instead of [CRITICAL] list index out of range) to highlight the issue, and advise the user of to either:
update the kraft.yaml file
redo their build process to generate the correct file name
Let kraft run provide an option to get the name/path of the binary to run
As kraft is under refactoring and the new tools KraftKit will be released soon, I am going to open a PR only regarding the kraft run issue since it has more influence than the kraft build one.
kraft
uses thename
field fromkraft.yaml
to retrieve the kernel binary file to conduct the build/run tasks. But if users usemake menuconfig
to configure the app, the default binary name would be the directory name. Such mixing up may lead to the following two confusions if thename
field ofkraft.yaml
does not match the directory name:kraft build
: if the configuration is correct, the build process will succeed, but nothing will be outputted afterSuccessfully built unikernels:
, which is weird.kraft run
:kraft
will not retrieve any binary file. Thus, it will output an error message[CRITICAL] list index out of range
After discussing with the community, two acceptable solutions are raised:
[CRITICAL] list index out of range
) to highlight the issue, and advise the user of to either:kraft run
provide an option to get the name/path of the binary to runAs kraft is under refactoring and the new tools KraftKit will be released soon, I am going to open a PR only regarding the
kraft run
issue since it has more influence than thekraft build
one.Issue #36 seems related to this issue, too.
The text was updated successfully, but these errors were encountered: