From 0e9def062dc71e8732e189ac241fe9d1f69da0b7 Mon Sep 17 00:00:00 2001 From: Cezar Craciunoiu Date: Wed, 2 Oct 2024 13:31:40 +0300 Subject: [PATCH] fix(governctl): Add unknown commits as exception Because of how governctl structures temp repos it makes it impossible for checkpatch to look behind and check if a commit in a body is referenced correctly. This is fine. It can be checked by hand with the script and can also be observed in GitHub if the sha mentioned is invalid. Signed-off-by: Cezar Craciunoiu --- cmd/governctl/pr/check/patch.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/governctl/pr/check/patch.go b/cmd/governctl/pr/check/patch.go index 39ece04..eb95ff1 100644 --- a/cmd/governctl/pr/check/patch.go +++ b/cmd/governctl/pr/check/patch.go @@ -66,7 +66,7 @@ func NewPatch() *cobra.Command { } func (opts *Patch) Run(ctx context.Context, args []string) error { - var extraIgnores []string + var extraIgnores = []string{"UNKNOWN_COMMIT_ID"} ghOrg, ghRepo, ghPrId, err := cmdutils.ParseOrgRepoAndPullRequestArgs(args) if err != nil {