Remove serde dependency from segmenter with lstm feature. (#2904)

Author: makotokato

Cargo.lock

@@ -31,10 +31,9 @@ skip_optional_dependencies = true
 icu_collections = { version = "1.0.0", path = "../../components/collections" }
 icu_provider = { version = "1.0.0", path = "../../provider/core", features = ["macros"] }
 serde = { version = "1.0", default-features = false, features = ["derive", "alloc"], optional = true }
-serde_json = { version = "1.0", default-features = false, features = ["alloc"] }
 zerovec = { version = "0.9", path = "../../utils/zerovec", features = ["yoke"] }
 databake = { version = "0.1.0", path = "../../utils/databake", optional = true, features = ["derive"] }
-ndarray = { version = "0.15.5", default-features = false, optional = true, features = ["serde"] }
+ndarray = { version = "0.15.5", default-features = false, optional = true }
 num-traits = { version = "0.2", default-features = false, optional = true, features = ["libm"] }
 icu_locid = { version = "1.0.0", path = "../../components/locid" }
 utf8_iter = "1.0.3"
@@ -43,7 +42,8 @@ displaydoc = { version = "0.2.3", default-features = false }
 [dev-dependencies]
 criterion = "0.3"
 icu_testdata = { path = "../../provider/testdata", default-features = false, features = ["buffer", "icu_segmenter"] }
-serde-json-core = { version = "0.4", features = ["std"] }
+serde = { version = "1.0", default-features = false, features = ["derive"] }
+serde_json = "1.0"
 icu = { path = "../../components/icu", features = ["experimental"]}
 
 [lib]
@@ -61,6 +61,6 @@ required-features = ["lstm"]
 [features]
 default = []
 std = []
-lstm = ["ndarray", "num-traits", "serde"]
+lstm = ["ndarray", "num-traits"]
 serde = ["dep:serde", "zerovec/serde", "icu_collections/serde", "icu_provider/serde"]
 datagen = ["serde", "databake", "zerovec/databake", "icu_collections/databake"]

experimental/segmenter/Cargo.toml

@@ -238,22 +238,22 @@ mod tests {
     use super::*;
     use crate::provider::GraphemeClusterBreakDataV1Marker;
     use icu_provider::prelude::*;
-    use serde::{Deserialize, Serialize};
+    use serde::Deserialize;
     use std::fs::File;
     use std::io::BufReader;
 
     /// `TestCase` is a struct used to store a single test case.
     /// Each test case has two attributs: `unseg` which denots the unsegmented line, and `true_bies` which indicates the Bies
     /// sequence representing the true segmentation.
-    #[derive(PartialEq, Debug, Serialize, Deserialize)]
+    #[derive(PartialEq, Debug, Deserialize)]
     pub struct TestCase {
         pub unseg: String,
         pub expected_bies: String,
         pub true_bies: String,
     }
 
     /// `TestTextData` is a struct to store a vector of `TestCase` that represents a test text.
-    #[derive(PartialEq, Debug, Serialize, Deserialize)]
+    #[derive(PartialEq, Debug, Deserialize)]
     pub struct TestTextData {
         pub testcases: Vec<TestCase>,
     }

experimental/segmenter/src/lstm_bies.rs

@@ -53,9 +53,5 @@ rustflags = ["--cfg=ops_bound", "--cfg=core_reverse", "--cfg=de_boxed_c_str", "-
 [gn.package.serde_derive."1.0.130"]
 rustflags = ["--cfg=underscore_consts", "--cfg=ptr_addr_of"]
 
-# TODO: Determine the correct rustflags for serde_json
-[gn.package.serde_json."1.0.69"]
-rustflags = []
-
 [gn.package.syn."1.0.81"]
 rustflags = []

ffi/gn/Cargo.lock

@@ -627,7 +627,6 @@ rust_library("icu_segmenter-v0_7_0") {
   deps += [ ":icu_collections-v1_0_0" ]
   deps += [ ":icu_locid-v1_0_0" ]
   deps += [ ":icu_provider-v1_0_1" ]
-  deps += [ ":serde_json-v1_0_69" ]
   deps += [ ":utf8_iter-v1_0_3" ]
   deps += [ ":zerovec-v0_9_1" ]
 
@@ -669,25 +668,6 @@ rust_library("icu_timezone-v1_0_0") {
   visibility = [ ":*" ]
 }
 
-rust_library("itoa-v0_4_8") {
-  crate_name = "itoa"
-  crate_root = "//ffi/gn/vendor/itoa/src/lib.rs"
-  output_name = "itoa-9e27afdde10ba0b5"
-
-  deps = []
-
-  rustenv = []
-
-  rustflags = [
-    "--cap-lints=allow",
-    "--edition=2015",
-    "-Cmetadata=9e27afdde10ba0b5",
-    "-Cextra-filename=-9e27afdde10ba0b5",
-  ]
-
-  visibility = [ ":*" ]
-}
-
 rust_library("lazy_static-v1_4_0") {
   crate_name = "lazy_static"
   crate_root = "//ffi/gn/vendor/lazy_static/src/lib.rs"
@@ -928,29 +908,6 @@ rust_proc_macro("serde_derive-v1_0_130") {
   visibility = [ ":*" ]
 }
 
-rust_library("serde_json-v1_0_69") {
-  crate_name = "serde_json"
-  crate_root = "//ffi/gn/vendor/serde_json/src/lib.rs"
-  output_name = "serde_json-3a9f5b638834f68f"
-
-  deps = []
-  deps += [ ":itoa-v0_4_8" ]
-  deps += [ ":ryu-v1_0_5" ]
-  deps += [ ":serde-v1_0_130" ]
-
-  rustenv = []
-
-  rustflags = [
-    "--cap-lints=allow",
-    "--edition=2018",
-    "-Cmetadata=3a9f5b638834f68f",
-    "-Cextra-filename=-3a9f5b638834f68f",
-    "--cfg=feature=\"alloc\"",
-  ]
-
-  visibility = [ ":*" ]
-}
-
 rust_library("smallvec-v1_10_0") {
   crate_name = "smallvec"
   crate_root = "//ffi/gn/vendor/smallvec/src/lib.rs"