Error handling event improvment

[adi130987]

Improve error data object sent in fail custom event.
Right now, to access received errors in on-fail event handler, you have to use response.detail.request.detail.request.response.

Replaceing

          this.fire('fail', {
            request: event,
            error: error.error
          }, {bubbles: false});

with

          this.fire('fail', {
            request: event.detail.request,
            errors: event.detail.request.response
          }, {bubbles: false});

might be a more useful change.

[DonNicoJs]

Not always, for example in t2f we use: response.detail.request.detail.request.xhr.response

…

On Wed, Jan 25, 2017 at 11:33 AM Adrian Hangan ***@***.***> wrote: Improve error data object sent in fail custom event. Right now, to access received errors in on-fail event handler, you have to use response.detail.request.detail.request.response. Replaceing this.fire('fail', { request: event, error: error.error }, {bubbles: false}); with this.fire('fail', { request: event.detail.request, errors: event.detail.request.response }, {bubbles: false}); might be a more useful change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFngdjRswdWlggKOlzY9WAgO7OBQyfXrks5rVyRYgaJpZM4LtUn_> .