Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Passing Command-Line Arguments via Environment #758

Closed
tinxx opened this issue Aug 8, 2024 · 0 comments · Fixed by #820
Closed

Allow Passing Command-Line Arguments via Environment #758

tinxx opened this issue Aug 8, 2024 · 0 comments · Fixed by #820
Assignees
@tinxx
Labels
Improvement Improvement of existing features

Comments

@tinxx
Copy link
Collaborator

tinxx commented Aug 8, 2024

Currently, parameters like the server password (--password) are passed to SEE as a command-line parameters.
This is suboptimal because passwords will show up in the operating system's process list.

The goal of this issue is to take values from environment variables.

The Gameserver container should be adapted to make use of this via its run.sh script.
@tinxx tinxx added the Improvement Improvement of existing features label Aug 8, 2024
tinxx added a commit that referenced this issue Jan 16, 2025
@tinxx
evaluate environment variables (#758)
d68745b 
Allow passing server configuration via environment.
@tinxx tinxx mentioned this issue Jan 16, 2025
Merged
@tinxx tinxx self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinxx tinxx

Labels
Improvement Improvement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved AddNode placement (+ additional fixes) uni-bremen-agst/SEE
1 participant
@tinxx