Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Interface for Code Cities #755

Open
tinxx opened this issue Aug 7, 2024 · 1 comment
Open

Unified Interface for Code Cities #755

tinxx opened this issue Aug 7, 2024 · 1 comment
Labels
Improvement Improvement of existing features

Comments

@tinxx
Copy link
Collaborator

tinxx commented Aug 7, 2024

In #753, a process for the synchronization of Code Cities has been implemented. Code Cities are stored on a back-end server and downloaded by clients when the server is joined.

Currently, the instantiation of downloaded Code Cities expects the process to be equivalent to that of a SEECity.

The goal of this issue is to define an interface that can be used instead. This is necessary because not all Code Cities extend SEECity and even if they do, they might implement additional steps for loading and drawing data.

@tinxx tinxx added the Improvement Improvement of existing features label Aug 7, 2024
@koschke
Copy link
Collaborator

koschke commented Aug 7, 2024

SEECityEvolution inherits from AbstractSEECity, so it makes sense to just add abstract methods to the latter.

Please take note that those cities are just containers for parameterizing the creation of code cities. The actual loading is done by classes derived from GraphProvider, which are part of a code city's parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement of existing features
Projects
None yet
Development

No branches or pull requests

2 participants