From 1303e7c9877b07bf0964fca7dbb6a14f0ba345af Mon Sep 17 00:00:00 2001
From: nichenqin <nichenqin@hotmail.com>
Date: Fri, 29 Nov 2024 10:13:59 +0800
Subject: [PATCH] fix: allow to bulk update record without filter

---
 .../bulk-update-records/bulk-update-records.svelte  | 13 +++++++------
 .../commands/src/bulk-update-records.command.ts     |  2 +-
 packages/i18n/src/i18n/en/index.ts                  |  3 ++-
 packages/i18n/src/i18n/es/index.ts                  |  3 ++-
 packages/i18n/src/i18n/i18n-types.ts                |  8 ++++++++
 packages/i18n/src/i18n/ja/index.ts                  |  3 ++-
 packages/i18n/src/i18n/ko/index.ts                  |  3 ++-
 packages/i18n/src/i18n/zh/index.ts                  |  3 ++-
 .../records/record/dto/bulk-update-records.dto.ts   |  2 +-
 .../services/methods/bulk-update-records.method.ts  | 10 +++-------
 10 files changed, 30 insertions(+), 20 deletions(-)

diff --git a/apps/frontend/src/lib/components/blocks/bulk-update-records/bulk-update-records.svelte b/apps/frontend/src/lib/components/blocks/bulk-update-records/bulk-update-records.svelte
index b0aef2d4f..84f610aac 100644
--- a/apps/frontend/src/lib/components/blocks/bulk-update-records/bulk-update-records.svelte
+++ b/apps/frontend/src/lib/components/blocks/bulk-update-records/bulk-update-records.svelte
@@ -64,10 +64,6 @@
   })
 
   const updateRecords = async (values: any) => {
-    if (!filter) {
-      return
-    }
-
     const selectedSchema = $table.schema.getMutableSchema(selectedFields)
     const validated = await form.validateForm({
       update: true,
@@ -181,7 +177,7 @@
       <div class="-mx-4 flex justify-end border-t py-2 pt-4">
         <Button
           size="sm"
-          disabled={!filter || !selectedFields.length}
+          disabled={!selectedFields.length}
           class="mr-5"
           on:click={() => {
             open = true
@@ -237,8 +233,13 @@
       <AlertDialog.Title>{$LL.table.record.bulkUpdate.title()}</AlertDialog.Title>
       <AlertDialog.Description>{$LL.table.record.bulkUpdate.description()}</AlertDialog.Description>
     </AlertDialog.Header>
+    {#if !filter}
+      <Alert.Root class="border-yellow-300 bg-yellow-50 text-yellow-700">
+        <Alert.Description>{$LL.table.record.bulkUpdate.noFilterAlert()}</Alert.Description>
+      </Alert.Root>
+    {/if}
     <AlertDialog.Footer>
-      <AlertDialog.Cancel>{$LL.table.common.cancel()}</AlertDialog.Cancel>
+      <AlertDialog.Cancel>{$LL.common.cancel()}</AlertDialog.Cancel>
       <AlertDialog.Action
         on:click={() => {
           if (values) {
diff --git a/packages/commands/src/bulk-update-records.command.ts b/packages/commands/src/bulk-update-records.command.ts
index 598cc5365..4a4bcca2c 100644
--- a/packages/commands/src/bulk-update-records.command.ts
+++ b/packages/commands/src/bulk-update-records.command.ts
@@ -16,7 +16,7 @@ export class BulkUpdateRecordsCommand extends Command implements IBulkUpdateReco
   public readonly tableId?: string
   public readonly baseName?: string
   public readonly tableName?: string
-  public readonly filter: IViewFilterGroup
+  public readonly filter?: IViewFilterGroup
   public readonly values: IRecordValues
   public readonly isOpenapi?: boolean
 
diff --git a/packages/i18n/src/i18n/en/index.ts b/packages/i18n/src/i18n/en/index.ts
index aa630d903..e35c55083 100644
--- a/packages/i18n/src/i18n/en/index.ts
+++ b/packages/i18n/src/i18n/en/index.ts
@@ -175,7 +175,8 @@ const record = {
     continue: 'Continue',
     noRecordsUpdated: 'No records updated',
     recordsUpdated: '{count} records updated successfully',
-    button: 'Bulk Update'
+    button: 'Bulk Update',
+    noFilterAlert: 'No filter, will update all records, please be careful!'
   },
   reference: {
     link: 'Link Records',
diff --git a/packages/i18n/src/i18n/es/index.ts b/packages/i18n/src/i18n/es/index.ts
index 83596777f..34c6482a8 100644
--- a/packages/i18n/src/i18n/es/index.ts
+++ b/packages/i18n/src/i18n/es/index.ts
@@ -174,7 +174,8 @@ const record = {
     continue: 'Continuar',
     noRecordsUpdated: 'No hay registros actualizados',
     recordsUpdated: '{count} registros actualizados correctamente',
-    button: 'Actualizar en masa'
+    button: 'Actualizar en masa',
+    noFilterAlert: 'No hay filtro, se actualizarán todos los registros, por favor, ten cuidado!'
   },
   reference: {
     link: 'enlace de registro',
diff --git a/packages/i18n/src/i18n/i18n-types.ts b/packages/i18n/src/i18n/i18n-types.ts
index c93dad95f..82155c985 100644
--- a/packages/i18n/src/i18n/i18n-types.ts
+++ b/packages/i18n/src/i18n/i18n-types.ts
@@ -1104,6 +1104,10 @@ type RootTranslation = {
 				 * B​u​l​k​ ​U​p​d​a​t​e
 				 */
 				button: string
+				/**
+				 * N​o​ ​f​i​l​t​e​r​,​ ​w​i​l​l​ ​u​p​d​a​t​e​ ​a​l​l​ ​r​e​c​o​r​d​s​,​ ​p​l​e​a​s​e​ ​b​e​ ​c​a​r​e​f​u​l​!
+				 */
+				noFilterAlert: string
 			}
 			reference: {
 				/**
@@ -3471,6 +3475,10 @@ export type TranslationFunctions = {
 				 * Bulk Update
 				 */
 				button: () => LocalizedString
+				/**
+				 * No filter, will update all records, please be careful!
+				 */
+				noFilterAlert: () => LocalizedString
 			}
 			reference: {
 				/**
diff --git a/packages/i18n/src/i18n/ja/index.ts b/packages/i18n/src/i18n/ja/index.ts
index 5103b11c3..e6e390031 100644
--- a/packages/i18n/src/i18n/ja/index.ts
+++ b/packages/i18n/src/i18n/ja/index.ts
@@ -175,7 +175,8 @@ const record = {
     continue: '続行',
     noRecordsUpdated: 'レコードが更新されません',
     recordsUpdated: '{count} 件のレコードが更新に成功しました',
-    button: '一括更新'
+    button: '一括更新',
+    noFilterAlert: 'フィルターがないため、すべてのレコードが更新されます。慎重に操作してください！'
   },
   noRecord: 'レコードがありません',
   reference: {
diff --git a/packages/i18n/src/i18n/ko/index.ts b/packages/i18n/src/i18n/ko/index.ts
index c100703da..5224af857 100644
--- a/packages/i18n/src/i18n/ko/index.ts
+++ b/packages/i18n/src/i18n/ko/index.ts
@@ -174,7 +174,8 @@ const record = {
     continue: '계속',
     noRecordsUpdated: '업데이트된 레코드가 없습니다',
     recordsUpdated: '{count} 개의 레코드가 성공적으로 업데이트되었습니다',
-    button: '일괄 업데이트'
+    button: '일괄 업데이트',
+    noFilterAlert: '필터가 없습니다. 모든 레코드가 업데이트됩니다. 주의하세요!'
   },
   reference: {
     link: '연결 레코드',
diff --git a/packages/i18n/src/i18n/zh/index.ts b/packages/i18n/src/i18n/zh/index.ts
index 590ba3bef..533b23490 100644
--- a/packages/i18n/src/i18n/zh/index.ts
+++ b/packages/i18n/src/i18n/zh/index.ts
@@ -174,7 +174,8 @@ const record = {
     continue: '继续',
     noRecordsUpdated: '没有记录更新',
     recordsUpdated: '{count} 条记录更新成功',
-    button: '批量更新'
+    button: '批量更新',
+    noFilterAlert: '没有筛选条件, 将会更新所有记录，请谨慎操作！'
   },
   reference: {
     link: '关联记录',
diff --git a/packages/table/src/modules/records/record/dto/bulk-update-records.dto.ts b/packages/table/src/modules/records/record/dto/bulk-update-records.dto.ts
index 59d367109..1238d4c01 100644
--- a/packages/table/src/modules/records/record/dto/bulk-update-records.dto.ts
+++ b/packages/table/src/modules/records/record/dto/bulk-update-records.dto.ts
@@ -3,7 +3,7 @@ import { viewFilterGroup } from "../../../views"
 import { recordValues } from "../record-values.vo"
 
 export const bulkUpdateRecordsDTO = z.object({
-  filter: viewFilterGroup,
+  filter: viewFilterGroup.optional(),
   values: recordValues,
   isOpenapi: z.boolean().optional(),
 })
diff --git a/packages/table/src/modules/records/services/methods/bulk-update-records.method.ts b/packages/table/src/modules/records/services/methods/bulk-update-records.method.ts
index 6faab7757..f6f699846 100644
--- a/packages/table/src/modules/records/services/methods/bulk-update-records.method.ts
+++ b/packages/table/src/modules/records/services/methods/bulk-update-records.method.ts
@@ -1,4 +1,4 @@
-import { Some, type Option } from "@undb/domain"
+import { None, Some, type Option } from "@undb/domain"
 import type { IUniqueTableDTO } from "../../../../dto"
 import { withUniqueTable } from "../../../../specifications"
 import { getSpec, replaceCondtionFieldNameWithFieldId } from "../../../schema/fields/condition"
@@ -14,15 +14,11 @@ export async function bulkUpdateRecordsMethod(
   const table = (await this.tableRepository.findOne(Some(ts))).expect("Table not found")
 
   let filter = dto.filter
-  if (dto.isOpenapi) {
+  if (dto.isOpenapi && filter) {
     filter = replaceCondtionFieldNameWithFieldId(filter, table.schema)
   }
 
-  const spec = getSpec(table.schema, filter) as Option<RecordComositeSpecification>
-
-  if (spec.isNone()) {
-    throw new Error("Invalid fjjilter")
-  }
+  const spec = (filter ? getSpec(table.schema, filter) : None) as Option<RecordComositeSpecification>
 
   const records = await this.repo.find(table, spec)
   if (records.length === 0) {