Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean false error logs in price feeder #1529

Open
4 tasks
robert-zaremba opened this issue Oct 27, 2022 · 0 comments
Open
4 tasks

Clean false error logs in price feeder #1529

robert-zaremba opened this issue Oct 27, 2022 · 0 comments
Assignees
Milestone

Comments

@robert-zaremba
Copy link
Member

Summary

Errors should be handled by error values, not logs at the origination.
These creates lot of spam messages in Peggo

Problem Definition

We constantly see the following blocks produced by oracle module in Peggo:

  1. ERR oracle tick failed error="error on computing tvwap for quote:
  2. [umeed.service] 1:38AM ERR Stopping peer for error err=EOF module=p2p peer={"Data":{},"Logger":{}}
  3. [peggod.service] 4:05PM ERR Error on receive message length=74 provider=huobi

Proposal

  1. don't log errors in library code. Instead return errors.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba self-assigned this Oct 27, 2022
@robert-zaremba robert-zaremba changed the title Clean false error logs Clean false error logs in price feeder Nov 14, 2022
@robert-zaremba robert-zaremba added this to the v3.4 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant