Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze Bridge via Non-UTF8/long Token Name/Symbol/Denom #70

Open
4 tasks
facundomedica opened this issue Nov 27, 2021 · 3 comments
Open
4 tasks

Freeze Bridge via Non-UTF8/long Token Name/Symbol/Denom #70

facundomedica opened this issue Nov 27, 2021 · 3 comments
Labels

Comments

@facundomedica
Copy link

I haven't personally checked this one. I don't understand if the fix needs to be made on the contract or on the peggo side.

Refs:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@facundomedica
Copy link
Author

facundomedica commented Nov 30, 2021

I've tested code-423n4/2021-08-gravitybridge-findings#4 and couldn't replicate it with the data provided. (https://goerli.etherscan.io/tx/0xd2dd31ca4821d4e4e8205dc3e6a83cf5078350e0e02707eedc33752f39b25dbb)

I've tested code-423n4/2021-08-gravitybridge-findings#5 and couldn't replicate it with adding a ton of characters. (https://goerli.etherscan.io/tx/0xc8939370c557c798a8bfcb737bd486278c173a0469878623850cbb3e32c99835)

I think that if this issue happens then the problem is not with the contract but with Peggo or/and Peggy; so I'll remove the label

@alexanderbez
Copy link

@facundomedica what's the latest here? Can we close this or is it still a vulnerability?

@facundomedica
Copy link
Author

I'm not sure. I couldn't replicate it, but reading through the linked issues, this is still valid. There are some solutions being discussed:

I just thought about testing it by sending random bytes, would that be enough to close this? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants