Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode(s) with blank title break browsing #4

Open
trevormunoz opened this issue Mar 12, 2021 · 7 comments
Open

Episode(s) with blank title break browsing #4

trevormunoz opened this issue Mar 12, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@trevormunoz
Copy link
Member

In verifying that #3 was resolved (🎉 ), I noticed that if an episode has a blank title it is impossible/difficult to reach the episode page via browsing from programs. See e.g. https://unlocking.netlify.app/programs/over-the-back-fence-and-transatlantic-profile/

Screen Shot 2021-03-12 at 9 54 54 AM

@trevormunoz trevormunoz added the bug Something isn't working label Mar 12, 2021
@edsu
Copy link
Collaborator

edsu commented Mar 13, 2021

I see this particular one has been updated in Airtable with a title of Over the Back Fence (date unknown). I think that suggests a way for the fetch-episodes import to assign a temporary episode title using the series title when an episode title is not available?

Screenshot from 2021-03-13 06-32-30

@edsu
Copy link
Collaborator

edsu commented Mar 13, 2021

Alternatively I guess the import could fail and alert that the episode needs to be assigned a title.

@trevormunoz
Copy link
Member Author

Based on a comment in Slack, it sounds like @ssapienza found the same list using Airtable and plans to update the underlying data.

+1 to the import in fetch-episodes emitting a warning

edsu added a commit that referenced this issue Mar 14, 2021
@edsu
Copy link
Collaborator

edsu commented Mar 14, 2021

npm run fetch-episodes will now print out an error when importing episodes from Airtable that have an empty title. I guess we can leave this open until the data is fixed in Airtable and we have run fetch-episodes to add it to the application.

@trevormunoz
Copy link
Member Author

I think this commit also needs to get moved onto main to address #5

@edsu
Copy link
Collaborator

edsu commented Mar 15, 2021

I see this commit on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants