Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPublishedMediaCache.GetAtRoot() is not loading Children items #18211

Open
Fric-88 opened this issue Feb 3, 2025 · 1 comment
Open

IPublishedMediaCache.GetAtRoot() is not loading Children items #18211

Fric-88 opened this issue Feb 3, 2025 · 1 comment
Assignees
Labels

Comments

@Fric-88
Copy link

Fric-88 commented Feb 3, 2025

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.1

Bug summary

I see that IPublishedCache.GetAtRoot() is obsolete now in Umbraco 15, but it seems that something also changed in how it works going from 15.1.0 to 15.1.1

Specifics

I Use this snippet to get all of my items from Media section:

public IEnumerable<IPublishedContent> GetAllMedia()
{
    if (contextAccessor.TryGetUmbracoContext(out var context) == false)
        return [];

    var mediaRoot = context.Media?.GetAtRoot() ?? [];
   
    return mediaRoot.DescendantsOrSelf<IPublishedContent>();
}

Up until 15.1.1 the DescendantsOrSelf() would return a collection with all the items at Root and all of its Children , in later versions Children are not loaded at all and could not be enumerated.

Im not sure if this is a bug or intended.

Anyways im not sure how to get all media with suggested new Interfaces (IDocumentNavigationQueryService, possibly IMediaNavigationQueryService in my case).

Steps to reproduce

Run the debugger trough the snippet above and look at the returned values Children.

Expected result / actual result

No response

Copy link

github-actions bot commented Feb 3, 2025

Hi there @Fric-88!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants