Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to retrieve dictionary items by id (DictionaryCacheRefresherNotification) #18157

Open
jveer opened this issue Jan 29, 2025 · 3 comments
Open
Assignees
Labels

Comments

@jveer
Copy link

jveer commented Jan 29, 2025

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.2

Bug summary

I'm currently working on a custom caching layer for dictionary items, in which I want to use the DictionaryCacheRefresherNotification. However, this notification only provides the integer id:
Image

Before we were able to retrieve the dictionary items by the id through the ILocalizationService, but that service is obsolete. The new IDictionaryItemService only allows to retrieve by Guid or ItemKey.

If Umbraco doesn't want to use the integer id's anymore, I think the notification needs to be updated to include the Guid, ItemKey or both.

Specifics

No response

Steps to reproduce

See summary

Expected result / actual result

Being able to retrieve the dictionary item based on the object passed in DictionaryCacheRefresherNotification.

@jveer jveer added the type/bug label Jan 29, 2025
Copy link

Hi there @jveer!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@kjac kjac self-assigned this Jan 29, 2025
@kjac
Copy link
Contributor

kjac commented Jan 29, 2025

Thanks for reaching out @jveer ... I'll have a look at this and come back with a path forward 👍

@kjac
Copy link
Contributor

kjac commented Feb 5, 2025

Quick follow-up on this one.

We will eventually be moving away from publicly facing integer IDs. This is a process, and it takes time. And we need to ensure that the "data journeys" that are currently tied to integer IDs have a path to move to GUID keys instead. Specifically for notifications, this is likely to be quite breaking, although we still aim to come up with something that allows for a graceful transition at the consumer side.

For the time being, you'll have to use the deprecated ILocalizationService to fetch dictionary items by their IDs. We have flagged it internally as "do not remove" until we've found a solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants