Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging of BadNoMatch is not correct #816

Open
Tracked by #912
Kantiran91 opened this issue Aug 26, 2024 · 2 comments
Open
Tracked by #912

Logging of BadNoMatch is not correct #816

Kantiran91 opened this issue Aug 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Kantiran91
Copy link
Member

The current version of the Client throws useless BadNoMatch Exceptions. I look in the code and I think this line is wrong and should be:
if (uaResult == UA_STATUSCODE_BADNOMATCH) {

@ccvca What do you think?

https://github.com/umati/Dashboard-OPCUA-Client/blob/5ad734e37dd30dfb63087de53f4317ca7f704677/OpcUaClient/OpcUaClient.cpp#L915C18-L915C20

@Kantiran91 Kantiran91 added the bug Something isn't working label Aug 26, 2024
@umati umati deleted a comment Aug 26, 2024
@ccvca
Copy link
Member

ccvca commented Aug 26, 2024

I dont know the full flow here anymore exactly. But I guess that this check ensures, that no logging is done for optional elements.

@wlkrm
Copy link
Contributor

wlkrm commented Jan 24, 2025

According to #811, this issue should already be resolved.
@ccvca, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants