Hi @lhoss Can you please take a look on the PR, and make it pass CI please.
The problem is lint failure in molecule check

The problem is lint failure in molecule check

I just fixed the lint issues in my changes .. but now there are 4 new lint issues on existing code (maybe due to some newer pip module ?!)
Those should be solved in a different PR cc @HorizonNet .

Anyway I'll now continue work on this PR, mainly testing if it works with a replica kdc 👍

@lhoss I opened PR to your rep with all fixes implemented so you can just pick
scigility#1
There are changes in Travic CI, molecule compatibility, and moved from python 2.7 to 3.6

@NadOby great work thx (and so quick)!
To get some more order, I propose to separate your fixes in separate PR, doing following:

• you open a PR to the upstream ultratendency repo, based on master (Adv.: it has travis enabled!)
  • or we can work on our scigility repo, then I'ld rebase your PR to master.. and then I merge it..
• and I'll rebase my (WIP!) branch on your work
  wdyt ?

I opened PR to your repo.
The proposition is to do all work in your scigility repo, cause major of work was done inside it, and then update ultratendency one.

This PR is now ready for review 👍

• Note: This PR should be merged only after merging PR Fix lint errors and update molecule for ansible v2.8 #23, because it contains it's commits (since I merged that PR°23 to my fork's master already)
• EDIT: ALL build issues fixed now!
  • fyi @NadOby (Review appreciated btw)

Hi, @lhoss I'm gone over the PR and there are errors when running molecule test on the default scenario name.
molecule test
You don't see it because it is commented out in .travis.yaml and rely on it to effectively check code validity.
So you can uncomment it in .travis.yaml
Excepting this small issue, all seems good.

We should also create a new version after merging this. In preparation I tagged the current master as v1.0.0. After this one I would create a v2.0.0.

@lhoss Do we also need to raise the minimum Ansible version?

@lhoss Do we also need to raise the minimum Ansible version?

Yes ansible 2 is a more than a must, but I recommend to put >2.5 (I ran a test with 2.5.8 and that worked 👍 )

@HorizonNet I fixed all your (good!) review comments.
Now (after lunch) I want to (force)push the latest state, rebased on #23 improvements, which will also make both molecule test scenarios (the simple/default one, and the kdc-with-replica) work. I hope you do not mind (github might not show the comment history after the force push)
After that I also want to push a small improvement in the add_princ_and_kt.yml, making it flexibler to re-use that outside the role (plus a keytab-based kinit 1-task include, which I often need in playbooks, and which is not worth to put into a separate role, but I like to abstract it out anyway 👍 )

ps: @HorizonNet wdyt about this new kinit checks feature, that I created in a derived branch?!
scigility/kerberos_server@support_multiple_kdcs...scigility:support_multiple_kdcs-with_kinit

For me it is useful to re-use in other playbooks, and to avoid to duplicate the logic (even though it is only 1 task , I know). Here an example with import_role:

  tasks:
    - import_role:
        name: ../../kerberos_server
        #name: kerberos_server
        tasks_from: kinit_kt
      vars:
        # ensure kerberos vars are set, that align with kerberos_server vars !
        _realm_name: "{{ kerberos_server_realm_name }}"
        _principal: "{{ hdfs_root_user }}/{{ ansible_fqdn }}"
        _keytab: "{{ hdfs_keytab }}"
        _kinit_user: "{{ hdfs_root_user }}"
      when: do_kinit | default(True) | bool
      tags: kinit