Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade Metal version for wider macOS compatibility #180

Closed
adamjs opened this issue Oct 9, 2019 · 0 comments
Closed

Downgrade Metal version for wider macOS compatibility #180

adamjs opened this issue Oct 9, 2019 · 0 comments
Assignees
@adamjs
Labels
bug Something isn't working
Milestone
v1.1

Comments

@adamjs
Copy link
Member

adamjs commented Oct 9, 2019

Reported from downstream package "Muon":

ImVexed/muon#11

Domain=CompilerError Code=1 "Function fragmentShader is using language version 2.1 which is
incompatible with this OS." UserInfo={NSLocalizedDescription=Function fragmentShader is using
language version 2.1 which is incompatible with this OS.}

The buildbots have macOS Mojave installed (Metal 2.1) and are using that by default. We need to modify AppCore build scripts on macOS to target earlier Metal for wider macOS compatibility.
@adamjs adamjs added the bug Something isn't working label Oct 9, 2019
@adamjs adamjs added this to the v1.1 milestone Oct 9, 2019
@adamjs adamjs self-assigned this Oct 9, 2019
adamjs added a commit to ultralight-ux/AppCore that referenced this issue Nov 8, 2019
@adamjs
Make Metal shaders target Metal Language Version 1.2 (macOS 10.12) fo…
928533c 
…r wider compatibility. References ultralight-ux/Ultralight#180
@adamjs adamjs closed this as completed in 2a237bd Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjs adamjs

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
1 participant
@adamjs