New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot be supported for 3.4 #15

Open

trp89 opened this issue Sep 11, 2024 · 1 comment

trp89 commented Sep 11, 2024 •

edited

Loading

In 3.3 every time we create a notification we get a hook when we fetch the notification contents that we can modify

https://github.com/pkp/ojs/blob/cdd3c2030edd372c0f1ba9281eed65d5e2ac64dc/classes/controllers/grid/issues/IssueGridHandler.inc.php#L521-L526

However in 3.4 we fetch an emailTemplate from the database instead, which doesn't give us a hook to override

https://github.com/pkp/ojs/blob/cd1b7b512df38e8f7c204432702e137ab06f0b64/classes/controllers/grid/issues/IssueGridHandler.php#L644-L652

Member

ctgraham commented Sep 12, 2024

This functionality is scheduled to be included in core in 3.5:
pkp/pkp-lib#5953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment