Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with new bleach #13

Open
kitterma opened this issue Feb 25, 2017 · 4 comments
Open

Incompatible with new bleach #13

kitterma opened this issue Feb 25, 2017 · 4 comments

Comments

@kitterma
Copy link

kitterma commented Feb 25, 2017

In order to adapt to the API changes in the current html5lib release, bleach is making substantial changes of its own:

https://github.com/mozilla/bleach

It does not appear to me that django-html_sanitizer is compatible with the bleach changes. If I run test.py in python2.7 with the new bleach I get:

python tests.py
Traceback (most recent call last):
File "tests.py", line 6, in
from sanitizer.templatetags.sanitizer import (sanitize, sanitize_allow,
ImportError: No module named templatetags.sanitizer

The new bleach is expected to be released next week.

@kitterma
Copy link
Author

bleach 2.0 is released now, so I guess that means this is more urgent.

@selwin
Copy link
Collaborator

selwin commented Mar 11, 2017

Could you please open a PR for this?

@kitterma
Copy link
Author

I don't understand what you are asking me to do (sorry). What do you want in the pull request? As far as I know, there's no code available for django-html_sanitizer to address the incompatibility.

@stinky2nine
Copy link

@selwin, I think @kitterma is asking django-html_sanitizer maintainers to add support for bleach v2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants