Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can ui-router/react support React18 new features? #1150

Open
Fangfanghao opened this issue Aug 10, 2022 · 6 comments
Open

Can ui-router/react support React18 new features? #1150

Fangfanghao opened this issue Aug 10, 2022 · 6 comments

Comments

@Fangfanghao
Copy link

If we want to support React18 new features ui-router/react, we have to replace
ReactDOM.render
to
createRoot

and replace
unmountComponentAtNode
with
unmount

Do we have a plan to suppport this?

@kadamgreene
Copy link

Yes, please. I'm getting errors about missing source maps because of Webpack 5 + React 18.

@codecdekamal
Copy link

Yes, I am also getting error because of Webpack 5 + React 18.

@pahen
Copy link

pahen commented Apr 18, 2023

Any news on this?

@Akshatjalan
Copy link

Currently No now but, For developers:

Stay informed: Keep an eye on the official announcements from the React and ui-router teams regarding updates and compatibility with React 18.

Check documentation: Review the documentation and release notes of ui-router and React 18 to understand any changes required for compatibility.

Be prepared for updates: Once React 18 is officially released, update your dependencies and check for any potential breaking changes in ui-router or other libraries you are using.

@andref
Copy link

andref commented Apr 7, 2024

This issue makes no sense. Ui-router/react does not mount the component tree. You will find no use of ReactDOM.render and unmountComponentAtNode in its codebase. It works just fine with React 18.

@chiptus
Copy link

chiptus commented Apr 17, 2024

@andref I think they refer to react-hybrid: ui-router/react-hybrid#580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants