From f1f3f0e58083b35ed15b4cbdc4e04e362b2e4bf8 Mon Sep 17 00:00:00 2001 From: Tim Fischer Date: Tue, 15 Oct 2024 14:40:35 +0000 Subject: [PATCH] fixed frontend eslint errors --- .../DocumentInformation/DocumentMetadataRow/utils.ts | 3 ++- frontend/src/views/analysis/ConceptsOverTime/CotaView.tsx | 6 +++--- .../src/views/annotation/DocumentRenderer/ImageMenu.tsx | 4 +--- frontend/src/views/tools/AutoLogbook/utils.ts | 2 ++ frontend/src/views/whiteboard/toolbar/EdgeEditMenu.tsx | 4 +--- frontend/src/views/whiteboard/toolbar/NodeEditMenu.tsx | 4 +--- frontend/src/views/whiteboard/toolbar/tools/ColorTool.tsx | 4 +++- frontend/src/views/whiteboard/toolbar/tools/NumberTool.tsx | 4 +++- .../src/views/whiteboard/types/customnodes/TextNodeData.ts | 2 +- 9 files changed, 17 insertions(+), 16 deletions(-) diff --git a/frontend/src/components/SourceDocument/DocumentInformation/DocumentMetadataRow/utils.ts b/frontend/src/components/SourceDocument/DocumentInformation/DocumentMetadataRow/utils.ts index c5d4e8c6d..e94cd2347 100644 --- a/frontend/src/components/SourceDocument/DocumentInformation/DocumentMetadataRow/utils.ts +++ b/frontend/src/components/SourceDocument/DocumentInformation/DocumentMetadataRow/utils.ts @@ -3,7 +3,8 @@ export const isValidHttpUrl = (string: string) => { try { url = new URL(string); - } catch (_) { + } catch (e) { + console.error(e); return false; } diff --git a/frontend/src/views/analysis/ConceptsOverTime/CotaView.tsx b/frontend/src/views/analysis/ConceptsOverTime/CotaView.tsx index b1a6cd3b0..9fcd8e022 100644 --- a/frontend/src/views/analysis/ConceptsOverTime/CotaView.tsx +++ b/frontend/src/views/analysis/ConceptsOverTime/CotaView.tsx @@ -1,9 +1,9 @@ import { CircularProgress, Portal, Typography } from "@mui/material"; import { useContext } from "react"; import { useParams } from "react-router-dom"; -import CotaHooks from "../../../api/CotaHooks"; -import { AppBarContext } from "../../../layouts/TwoBarLayout"; -import CotaViewContent from "./CotaViewContent"; +import CotaHooks from "../../../api/CotaHooks.ts"; +import { AppBarContext } from "../../../layouts/TwoBarLayout.tsx"; +import CotaViewContent from "./CotaViewContent.tsx"; function CotaView() { // global client state diff --git a/frontend/src/views/annotation/DocumentRenderer/ImageMenu.tsx b/frontend/src/views/annotation/DocumentRenderer/ImageMenu.tsx index 8308f9d66..eb66c0e83 100644 --- a/frontend/src/views/annotation/DocumentRenderer/ImageMenu.tsx +++ b/frontend/src/views/annotation/DocumentRenderer/ImageMenu.tsx @@ -7,15 +7,13 @@ import { useOpenSnackbar } from "../../../components/SnackbarDialog/useOpenSnack import { useAppDispatch } from "../../../plugins/ReduxHooks.ts"; import { ImageSearchActions } from "../../search/ImageSearch/imageSearchSlice.ts"; -interface ImageMenuProps {} - export interface ImageMenuHandle { open: (position: PopoverPosition, image: number | null | undefined) => void; close: () => void; } // eslint-disable-next-line no-empty-pattern -const ImageMenu = forwardRef(({}, ref) => { +const ImageMenu = forwardRef((_, ref) => { const navigate = useNavigate(); // local state diff --git a/frontend/src/views/tools/AutoLogbook/utils.ts b/frontend/src/views/tools/AutoLogbook/utils.ts index ffd5a9422..9f2dd5b26 100644 --- a/frontend/src/views/tools/AutoLogbook/utils.ts +++ b/frontend/src/views/tools/AutoLogbook/utils.ts @@ -74,6 +74,7 @@ export const action2TargetTitle = (action: ActionRead): string | null | undefine return undefined; } } catch (e) { + console.error(e); return undefined; } }; @@ -94,6 +95,7 @@ export const parseActionState = (input: string | null | undefined | null) => { try { return JSON.parse(input); } catch (e) { + console.error(e); throw new Error("Could not parse state as JSON (json is invalid)!"); } }; diff --git a/frontend/src/views/whiteboard/toolbar/EdgeEditMenu.tsx b/frontend/src/views/whiteboard/toolbar/EdgeEditMenu.tsx index 9341e2cee..00f99fb58 100644 --- a/frontend/src/views/whiteboard/toolbar/EdgeEditMenu.tsx +++ b/frontend/src/views/whiteboard/toolbar/EdgeEditMenu.tsx @@ -29,8 +29,6 @@ import SliderTool from "./tools/SliderTool.tsx"; import SolidDashedDottedTool from "./tools/SolidDashedDottedTool.tsx"; import TypographyVariantTool from "./tools/TypographyVariantTool.tsx"; -interface EdgeEditMenuProps {} - const arrow2icon: Record = { noarrow: , arrow: , @@ -55,7 +53,7 @@ export interface EdgeEditMenuHandle { close: () => void; } -const EdgeEditMenu = forwardRef((_, ref) => { +const EdgeEditMenu = forwardRef((_, ref) => { const reactFlowInstance = useReactFlow(); const [edges, setEdges] = useState[]>([]); diff --git a/frontend/src/views/whiteboard/toolbar/NodeEditMenu.tsx b/frontend/src/views/whiteboard/toolbar/NodeEditMenu.tsx index 16f942702..f2e914f52 100644 --- a/frontend/src/views/whiteboard/toolbar/NodeEditMenu.tsx +++ b/frontend/src/views/whiteboard/toolbar/NodeEditMenu.tsx @@ -21,14 +21,12 @@ import SliderTool from "./tools/SliderTool.tsx"; import SolidDashedDottedTool from "./tools/SolidDashedDottedTool.tsx"; import TypographyVariantTool from "./tools/TypographyVariantTool.tsx"; -interface NodeEditMenuProps {} - export interface NodeEditMenuHandle { open: (nodes: Node[]) => void; close: () => void; } -const NodeEditMenu = forwardRef((_, ref) => { +const NodeEditMenu = forwardRef((_, ref) => { const reactFlowInstance = useReactFlow(); const [nodes, setNodes] = useState[]>([]); diff --git a/frontend/src/views/whiteboard/toolbar/tools/ColorTool.tsx b/frontend/src/views/whiteboard/toolbar/tools/ColorTool.tsx index 99645371c..a50c25ae9 100644 --- a/frontend/src/views/whiteboard/toolbar/tools/ColorTool.tsx +++ b/frontend/src/views/whiteboard/toolbar/tools/ColorTool.tsx @@ -9,7 +9,9 @@ interface ColorToolProps { function ColorTool({ caption, color, onColorChange }: ColorToolProps) { let timeout: NodeJS.Timeout | undefined; const handleColorChange: React.ChangeEventHandler = (event) => { - timeout && clearTimeout(timeout); + if (timeout) { + clearTimeout(timeout); + } timeout = setTimeout(() => { const color = event.target.value; onColorChange(color); diff --git a/frontend/src/views/whiteboard/toolbar/tools/NumberTool.tsx b/frontend/src/views/whiteboard/toolbar/tools/NumberTool.tsx index c21b409c6..d8651664a 100644 --- a/frontend/src/views/whiteboard/toolbar/tools/NumberTool.tsx +++ b/frontend/src/views/whiteboard/toolbar/tools/NumberTool.tsx @@ -10,7 +10,9 @@ interface NumberToolProps { function NumberTool({ value, onValueChange, min, max }: NumberToolProps) { let timeout: NodeJS.Timeout | undefined; const handleStrokeWidthChange: React.ChangeEventHandler = (event) => { - timeout && clearTimeout(timeout); + if (timeout) { + clearTimeout(timeout); + } timeout = setTimeout(() => { onValueChange(parseInt(event.target.value)); }, 333); diff --git a/frontend/src/views/whiteboard/types/customnodes/TextNodeData.ts b/frontend/src/views/whiteboard/types/customnodes/TextNodeData.ts index f11980068..9d8c9d86e 100644 --- a/frontend/src/views/whiteboard/types/customnodes/TextNodeData.ts +++ b/frontend/src/views/whiteboard/types/customnodes/TextNodeData.ts @@ -1,3 +1,3 @@ import { TextData } from "../base/TextData.ts"; -export interface TextNodeData extends TextData {} +export type TextNodeData = TextData;