Add soil temperature and moisture IAU #2415
Conversation
tsga
force-pushed
the
feature/lnd_iau
branch
from
d0c0640
to
9ae4f54
Compare
|
Tagging relevant people here. Please add (tag) anyone you think should be aware. |
|
@tsga There should be an associated PR for the NoahMP changes in https://github.com/NOAA-EMC/noahmp, right? This component repo needs to have its internal NoahMP code updated to correspond to the changes in ufs-community/ccpp-physics#222. Please let me know if you need help with this or if I am mistaken. |
|
@tsga Since there is a new namelist to read in (according to https://github.com/ufs-community/ccpp-physics/pull/222/files#diff-13b994b587cb8a841246d6db7df55ef9ff6fc1269777b9fe1b2e704ce9da629bR138), will an example of this be added to this repository for testing purposes? |
@grantfirl yes there is an example namelist with the new Land IAU specific test at: Should I also add it as part of this repo (as one of the files)? |
@tsga @jkbk2004 As of now, if we merged your work, there would be no tests that are utilizing it, so it could be broken with subsequent code changes. You mention in this PR description that a new RT should be added, but the files haven't been modified to add it yet. You'd need to edit tests/rt.conf, commit the new namelist and refer to it in the new test file to be added in tests/tests, and have the new data staged on the testing platforms in order for the test to be set up to be exercised. |
|
@tsga Please see tsga#1, With these changes, I can use the new RT via: It compiles successfully, although the run fails because the data is not staged. When the data is staged, we can complete testing. |
Move DDTs to host
|
@grantfirl Thank you! I added the increment files to the INPUT dir of the test you set up and it runs successfully (I am working on the other issues of gracefully exiting when there are no files, etc, you mentioned earlier). |
@tsga I don't have permissions in that directory either. @jkbk2004 and/or other members of the UFS code management team can do this for us. |
@tsga @grantfirl I will follow up today. will keep you posted. |
|
@tsga /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501/FV3_input_data/INPUT_L127_gfsv17 is for C96 resolution. Do you want me to copy over /scratch2/NCEPDEV/land/data/DA/soil_moisture/LandIAU/INC/C96/sfc_inc.tile*.nc ? |
|
@tsga Or if you want to stay with with C48, we have C48 test case at /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501/FV3_input_data48/INPUT_L127_gfsv17. We can copy over your C48 sfc increment files there. Maybe both C48 and C96. Let me know. |
@jkbk2004 yes, let's stay with C48. And disregard the earlier directory. The C48 increments are at: /scratch2/NCEPDEV/land/data/DA/soil_moisture/LandIAU/INC/C48/INC3 |
|
@tsga /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501/FV3_input_data48/INPUT_L127_gfsv17/sfc_inc.tile*.nc is available. Once test is ok on hera, then we can rsync up on other machines. |
@barlage I would like to hear your opinion here. My impulse is to finalize the current pull request for ccpp-physics/fv3/ufs-wm and then start work for the component model separately. @grantfirl I am assuming there is no repo dependence here (like that exists between ccpp-physics->fv3->ufswm)? Whatever will be merged for ccpp-physics/noahmp will be ported to the NOAA-EMC/noahmp. |
@jkbk2004 I can now confirm that the land iau tests work on hera. The new baseline created for the "control_c48_lnd_iau_intel" test is at: |
Would the component model require changes to build with the changes to CCPP, or just require changes to use the land IAU? If the former, then the PRs should probably be concurrent, but if the latter, then I support @tsga 's impulse to finish this first, and then move on to the component model. |
I believe there will be an issue here due to change in the noahmpdrv_init subroutine. I set up a meeting with @uturuncoglu to discuss. |
* develop: [develop]: Documentation updates + Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) ufs-community#2464 + Update chunksizes for cubed sphere grid ufs-community#2465 (ufs-community#2463) First reconciliation PR from production/RRFS.v1 (ufs-community#2449) Add GFDL Land Model 4.0 (ufs-community#2146)
* develop: GW-RT global_control.nml modifications (ufs-community#2425)
Commit Queue Requirements:
Description:
Add Incremental Analysis Update (IAU) to soil temperature and moisture in the NoahMP land model of the UWM's CCPP.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Additional land-IAU specific test to be added: control_c48_intel_land_iau (based on the "control_c48_intel" test, with the only difference being the turning on of land IAU and soil temperature increment files inside INPUT directory). The test inputs are at:
/scratch1/NCEPDEV/da/Tseganeh.Gichamo/ccpp-physics/test/control_c48_intel_land_iau
Input data Changes:
soil temperature increment files inside INPUT directory
Library Changes/Upgrades:
Testing Log: