[DRAFT] Remove local copies of FindESMF from all components, update ESMF to 8.6.1 and MAPL to 2.46.3 #2406

DusanJovic-NOAA · 2024-08-23T14:08:49Z

Commit Queue Requirements:

Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
Commit 'test_changes.list' from previous step

Description:

This PR requires two libraries (ESMF v8.6.1 and MAPL v 2.64.3) to be installed on all supported machines. So far, I'm testing these updates on Hercules using ue-esmf-8.6.1-mapl-2.46.2 spack-stack.

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * stochastic_physics -

Priority:

Normal

Git Tracking

UFSWM:

Closes Should we update FindESMF.cmake and maybe the name of the imported esmf target #2399

Sub component Pull Requests:

AQM:
CDEPS:
CICE:
CMEPS:
CMakeModules:
FV3:
- ccpp-physics:
- atmos_cubed_sphere:
GOCART:
HYCOM:
MOM6:
NOAHMP:
WW3:
stochastic_physics:
None

UFSWM Blocking Dependencies:

Blocked by #
None

Changes

Regression Test Changes (Please commit test_changes.list):

PR Adds New Tests/Baselines.
PR Updates/Changes Baselines.
No Baseline Changes.

Input data Changes:

None.
New input data.
Updated input data.

Library Changes/Upgrades:

Required
- Library names w/versions:
- Git Stack Issue (JCSDA/spack-stack#)
No Updates

Testing Log:

…ation

bbakernoaa · 2024-09-13T18:43:44Z

@DusanJovic-NOAA If you are testing this with the head of the develop branch from GOCART (hash bf5cf04) then you need to update the tests/parm/gocart/SU2G_instance_SU.rc file

Specifically this line

It will need to be changed with

volcano_srcfilen_explosive: /dev/null
volcano_srcfilen_degassing: /PATH_TO_NEW_FILE/so2_volcanic_emissions_CARN_v202401.degassing_only.rc

I have a copy of this new file on hera: /scratch1/RDARCH/rda-arl-gpu/Barry.Baker/emissions/GEFS/nexus/VOLCANIC/so2_volcanic_emissions_CARN_v202401.degassing_only.rc

Once you have this I think your problems with updating gocart will be solved

DusanJovic-NOAA · 2024-09-17T18:49:06Z

I made the suggested change in SU2G_instance_SU.rc and now I get this error:

$ grep 00000 err
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01560    MAPL_EsmfRegridder.F90                   <destination masking with this regrid type is unsupported>
pe=00000 FAIL at line=01382    MAPL_EsmfRegridder.F90                   <status=1>
pe=00000 FAIL at line=00977    MAPL_AbstractRegridder.F90               <status=1>
pe=00000 FAIL at line=00097    NewRegridderManager.F90                  <status=1>
pe=00000 FAIL at line=01101    GriddedIO.F90                            <status=1>
pe=00000 FAIL at line=04539    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01468    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01838    MAPL_Generic.F90                         <status=1>
pe=00000 FAIL at line=01241    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01204    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01164    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00832    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00972    MAPL_CapGridComp.F90                     <status=1>

bbakernoaa · 2024-09-18T14:56:39Z

@DusanJovic-NOAA do you have the new MAPL/ESMF installed on hera?

DusanJovic-NOAA · 2024-09-18T17:04:44Z

@DusanJovic-NOAA do you have the new MAPL/ESMF installed on hera?

I don't. I already asked EPIC twice to install the updated version of MPAS.

DusanJovic-NOAA · 2024-09-24T16:05:10Z

@bbakernoaa I repeated the cpld_control_p8_intel test on Hercules with updated gocart (top of develop 327ff344) and MAPL 2.46.3 and it fails with the same error:

djovic@hercules-login-4: /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel
$ grep 00000 err
  0: pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
  0: pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
  0: pe=00000 FAIL at line=01560    MAPL_EsmfRegridder.F90                   <destination masking with this regrid type is unsupported>
  0: pe=00000 FAIL at line=01382    MAPL_EsmfRegridder.F90                   <status=1>
  0: pe=00000 FAIL at line=00977    MAPL_AbstractRegridder.F90               <status=1>
  0: pe=00000 FAIL at line=00097    NewRegridderManager.F90                  <status=1>
  0: pe=00000 FAIL at line=01101    GriddedIO.F90                            <status=1>
  0: pe=00000 FAIL at line=04539    ExtDataGridCompMod.F90                   <status=1>
  0: pe=00000 FAIL at line=01468    ExtDataGridCompMod.F90                   <status=1>
  0: pe=00000 FAIL at line=01838    MAPL_Generic.F90                         <status=1>
  0: pe=00000 FAIL at line=01241    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=01204    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=01164    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=00832    MAPL_CapGridComp.F90                     <status=1>
  0: pe=00000 FAIL at line=00972    MAPL_CapGridComp.F90                     <status=1>

I also updated SU2G_instance_SU.rc to include these two lines:

# Volcanic pointwise sources
volcano_srcfilen_explosive: /dev/null
volcano_srcfilen_degassing: ./so2_volcanic_emissions_CARN_v202401.degassing_only.rc

My run directory on Hercules is /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel

junwang-noaa · 2024-09-24T16:54:33Z

@weiyuan-jiang Can you access Hercules? May I ask if you can take a look as well?

weiyuan-jiang · 2024-09-24T17:13:41Z

@weiyuan-jiang Can you access Hercules? May I ask if you can take a look as well?

Yes, I will take a look

bena-nasa · 2024-09-25T17:45:17Z

I made the suggested change in SU2G_instance_SU.rc and now I get this error:

$ grep 00000 err
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01088    MAPL_CapGridComp.F90                     <status=41>
pe=00000 FAIL at line=01560    MAPL_EsmfRegridder.F90                   <destination masking with this regrid type is unsupported>
pe=00000 FAIL at line=01382    MAPL_EsmfRegridder.F90                   <status=1>
pe=00000 FAIL at line=00977    MAPL_AbstractRegridder.F90               <status=1>
pe=00000 FAIL at line=00097    NewRegridderManager.F90                  <status=1>
pe=00000 FAIL at line=01101    GriddedIO.F90                            <status=1>
pe=00000 FAIL at line=04539    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01468    ExtDataGridCompMod.F90                   <status=1>
pe=00000 FAIL at line=01838    MAPL_Generic.F90                         <status=1>
pe=00000 FAIL at line=01241    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01204    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=01164    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00832    MAPL_CapGridComp.F90                     <status=1>
pe=00000 FAIL at line=00972    MAPL_CapGridComp.F90                     <status=1>

This crash is not related to the volcanic emissions files. So changing the volcanic emissions files cannot cause this. Either something else was changed or changing the volcanic emissions files just meant the model got further and you hit a different problem.
Could be because of the v2.46.3 update? But how you got to that block is mysterious, that is not the default Regridding option in anything so unless someone changed somehow how you got there is beyond me.

That said, the grid that is getting passed down to gocart and the cap to gocart, does that have a mask set on it somewhere else in UFS?

junwang-noaa · 2024-09-30T14:11:47Z

@DusanJovic-NOAA may I ask where your model source code is for the run /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel?

DusanJovic-NOAA · 2024-09-30T14:51:23Z

@DusanJovic-NOAA may I ask where your model source code is for the run /work2/noaa/stmp/djovic/stmp/djovic/FV3_RT/rt_4012304/cpld_control_p8_intel?

/work/noaa/fv3-cam/djovic/ufs/gocart_mapl/ufs-weather-model

junwang-noaa · 2024-09-30T16:20:19Z

From @bena-nasa: I have made branch:

https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4

with what should fix the issue you were seeing with MAPLv2.46.3, please try and let me know. If it fixes your issues we can make a v2.46.4 release of mapl and hotfix this onto our develop.

@RatkoVasic-NOAA would you please install this MAPL version on Hercules for us to test if it resolves the model failure? Thanks

GeorgeVandenberghe-NOAA · 2024-10-01T18:58:59Z

From @bena-nasa: I have made branch:

https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4

with what should fix the issue you were seeing with MAPLv2.46.3, please try and let me know. If it fixes your issues we can make a v2.46.4 release of mapl and hotfix this onto our develop.

@RatkoVasic-NOAA would you please install this MAPL version on Hercules for us to test if it resolves the model failure? Thank

What is the git syntax to get this new hotfix and build the new(er) MAPL? I am going to try to do this offline rather than waiting for possible down the road installation.

junwang-noaa · 2024-10-01T19:22:23Z

@RatkoVasic-NOAA @jkbk2004 @ulmononian May I ask if the EPIC library team can install the MAPL candidate_v2.46.4 in spack-stack 1.6.0?

We can't move on with the testing without the new library. Thanks

GeorgeVandenberghe-NOAA · 2024-10-01T19:27:06Z

How do I build this library offline? Git shell instructions especially needed.

…

On Tue, Oct 1, 2024 at 7:22 PM Jun Wang ***@***.***> wrote: @RatkoVasic-NOAA <https://github.com/RatkoVasic-NOAA> @jkbk2004 <https://github.com/jkbk2004> @ulmononian <https://github.com/ulmononian> May I ask if the EPIC library team can install the MAPL candidate_v2.46.4 <https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4> in spack-stack 1.6.0? We can't move on with the testing without the new library. Thanks — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FXNNPNIQ3Q6RNFD3Q3ZZLZANAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWG44DCMZSGQ> . You are receiving this because you commented.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

RatkoVasic-NOAA · 2024-10-01T20:06:41Z

@junwang-noaa @GeorgeVandenberghe-NOAA I can try to install that version. Which machine do you want to test?

junwang-noaa · 2024-10-02T14:30:43Z

@RatkoVasic-NOAA can you install it on Hercules? Thanks

RatkoVasic-NOAA · 2024-10-02T14:33:53Z

@RatkoVasic-NOAA can you install it on Hercules? Thanks

@junwang-noaa will do.

GeorgeVandenberghe-NOAA · 2024-10-02T15:36:13Z

For me, hercules. Also how do I build that version offline myself. Having trouble with the git to get that version.

…

On Tue, Oct 1, 2024 at 8:07 PM RatkoVasic-NOAA ***@***.***> wrote: @junwang-noaa <https://github.com/junwang-noaa> @GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> I can try to install that version. Which machine do you want to test? — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FWCTJI3LWIGDGGQLVDZZL6GTAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWHE3DGNJSGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

RatkoVasic-NOAA · 2024-10-02T15:48:40Z

@GeorgeVandenberghe-NOAA I have never installed MAPL outside of spack-stack.

@bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags:

    version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7")
    version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0")
    version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916")
    version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459")
    version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7")
    version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0")
    version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573")
    version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2")

GeorgeVandenberghe-NOAA · 2024-10-02T15:54:13Z

I think I need this tag to for a shell git followed by build. I have the build but haven't figured out how to get the source

…

On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA ***@***.***> wrote: @GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> I have never installed MAPL outside of spack-stack. @bena-nasa <https://github.com/bena-nasa> can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7") version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0") version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916") version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459") version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7") version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0") version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573") version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2") — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

GeorgeVandenberghe-NOAA · 2024-10-02T16:53:07Z

I need the git syntax to properly get this hotfix https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4

…

On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA ***@***.***> wrote: @GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> I have never installed MAPL outside of spack-stack. @bena-nasa <https://github.com/bena-nasa> can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7") version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0") version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916") version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459") version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7") version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0") version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573") version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2") — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

BrianCurtis-NOAA · 2024-10-02T16:58:40Z

I need the git syntax to properly get this hotfix https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4
…
On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA @.> wrote: @GeorgeVandenberghe-NOAA https://github.com/GeorgeVandenberghe-NOAA I have never installed MAPL outside of spack-stack. @bena-nasa https://github.com/bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7") version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0") version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916") version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459") version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7") version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0") version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573") version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2") — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY . You are receiving this because you were mentioned.Message ID: @.>
-- George W Vandenberghe Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 @.** 301-683-3769(work) 3017751547(cell)

I believe:

git remote add GEOS-ESM https://github.com/GEOS-ESM/MAPL
git remote update
git merge GEOS-ESM hotfix/bmauer/candidate_v2.46.4

(might be git merge GEOS-ESM/hotfix/bmauer/candidate_v2.46.4

BrianCurtis-NOAA · 2024-10-02T16:59:52Z

I typo'd, it's GEOS-ESM

GeorgeVandenberghe-NOAA · 2024-10-02T17:34:32Z

Dies not finding repository 46.3]$ cd MAPL ***@***.*** MAPL]$ git remote add GOES-ESM https://github.com/GOES-ESM/MAPL ***@***.*** MAPL]$ git remote update Fetching origin Fetching GOES-ESM Username for 'https://github.com': ... upon supplying this it fails to find the repository On Wed, Oct 2, 2024 at 4:59 PM Brian Curtis ***@***.***> wrote:

…

I need the git syntax to properly get this hotfix https://github.com/GEOS-ESM/MAPL/tree/hotfix/bmauer/candidate_v2.46.4 … <#m_-4507551138992535341_> On Wed, Oct 2, 2024 at 3:49 PM RatkoVasic-NOAA *@*.*> wrote: @GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> https://github.com/GeorgeVandenberghe-NOAA <https://github.com/GeorgeVandenberghe-NOAA> I have never installed MAPL outside of spack-stack. @bena-nasa <https://github.com/bena-nasa> https://github.com/bena-nasa <https://github.com/bena-nasa> can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags: version("2.48.0", sha256="60a0fc4fd82b1a05050666ae478da7d79d86305aff1643a57bc09cb5347323b7") version("2.47.2", sha256="d4ca384bf249b755454cd486a26bae76944a7cae3a706b9a7c9298825077cac0") version("2.47.1", sha256="ca3e94c0caa78a91591fe63603d1836196f5294d4baad7cf1d83b229b3a85916") version("2.47.0", sha256="66c862d2ab8bcd6969e9728091dbca54f1f420e97e41424c4ba93ef606088459") version("2.46.3", sha256="333e1382ab744302d28b6f39e7f5504c7919d77d2443d70af952f60cbd8f27e7") version("2.46.2", sha256="6d397ad73042355967de8ef5b521d6135c004f96e93ae7b215f9ee325e75c6f0") version("2.46.1", sha256="f3090281de6293b484259d58f852c45b98759de8291d36a4950e6d348ece6573") version("2.46.0", sha256="726d9588b724bd43e5085d1a2f8d806d548f185ed6b22a1b13c0ed06212d7be2") — Reply to this email directly, view it on GitHub <#2406 (comment) <#2406 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY <https://github.com/notifications/unsubscribe-auth/ANDS4FTDC6IPFORIDHYB7V3ZZQIXDAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGAZDAMJTGY> . You are receiving this because you were mentioned.Message ID: @.*> -- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 @.*** 301-683-3769(work) 3017751547(cell) I believe: git remote add GOES-ESM https://github.com/GOES-ESM/MAPL git remote update git merge GOES-ESM hotfix/bmauer/candidate_v2.46.4 (might be git merge GOES-ESM/hotfix/bmauer/candidate_v2.46.4 — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FVEG44S6NRDXZ6AZB3ZZQQ5PAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGE3DINZTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

lipan-NOAA · 2024-10-07T15:38:24Z

@DusanJovic-NOAA @junwang-noaa I'll test it and let you know. Thanks.

tclune · 2024-10-07T16:01:29Z

@bena-nasa can you please make a tag from your branch, I cannot install it in spack-stack. Here are available tags:

Ben is unfortunately on vacation until Columbus day. I'm pinging @mathomp4 for assistance.

mathomp4 · 2024-10-07T16:30:59Z

All. I'm testing now to make sure this doesn't affect GEOS (when merged into our current version of MAPL). If it works, I'll release v2.46.4 and GitFlow it up to main and develop. I'll also make a PR to spack mainline. @RatkoVasic-NOAA would you be able to make a PR into spack-stack wherever it is needed (not sure what version(s))?

RatkoVasic-NOAA · 2024-10-07T17:05:45Z

@mathomp4 no need for PR, I can get whatever version is tagged and install new spack-stack environment using that version of MAPL.

mathomp4 · 2024-10-07T17:07:08Z

@junwang-noaa @RatkoVasic-NOAA I have released MAPL 2.46.4:

https://github.com/GEOS-ESM/MAPL/releases/tag/v2.46.4

I'm waiting for our CI to be happy with the PR onto main and then I'll release MAPL 2.49.1 and make a PR to spack with the new versions.

RatkoVasic-NOAA · 2024-10-07T17:45:24Z

@mathomp4 great!
@junwang-noaa I'll create new environment on Hercules using that tag.

RatkoVasic-NOAA · 2024-10-07T19:23:04Z

@junwang-noaa [email protected]/[email protected] is ready on Hercules:
/work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core

mathomp4 · 2024-10-07T19:28:13Z

@junwang-noaa [email protected]/[email protected] is ready on Hercules: /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core

Fingers crossed it works!

GeorgeVandenberghe-NOAA · 2024-10-07T19:52:57Z

Instructions on how to load this in the UFS build environment??

…

On Mon, Oct 7, 2024 at 7:28 PM Matt Thompson ***@***.***> wrote: @junwang-noaa <https://github.com/junwang-noaa> ***@***.******@***.*** is ready on Hercules: /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core Fingers crossed it works! — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FQQWYV5E6FA6PZYPH3Z2LOGNAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXG4YTONJSGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

RatkoVasic-NOAA · 2024-10-07T20:35:53Z

Instructions on how to load this in the UFS build environment??
…

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core
module load stack-intel/2021.9.0
module load stack-intel-oneapi-mpi/2021.9.0
module load cmake/3.23.1

lipan-NOAA · 2024-10-07T21:22:03Z

With MAPL-2.64.4, it runs and passes the previous error stage, but still gives the error.

Logfile: /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/err
/work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/out

GeorgeVandenberghe-NOAA · 2024-10-08T10:42:10Z

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.8.0/envs/test1/install/modulefiles/Core module load stack-intel/2021.9.0 module load stack-intel-oneapi-mpi/2021.9.0 module load cmake/3.23.1 When I do this I cannot see mapl/2.46.4 I get from module spider Versions: mapl/2.40.3-esmf-8.6.0 mapl/2.46.3-esmf-8.6.1

…

On Mon, Oct 7, 2024 at 4:36 PM RatkoVasic-NOAA ***@***.***> wrote: Instructions on how to load this in the UFS build environment?? … <#m_-1404153467279152158_> module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.8.0/envs/test1/install/modulefiles/Core module load stack-intel/2021.9.0 module load stack-intel-oneapi-mpi/2021.9.0 module load cmake/3.23.1 — Reply to this email directly, view it on GitHub <#2406 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANDS4FQKPCU3N4PTARWOML3Z2LWEBAVCNFSM6AAAAABNAIK762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXHA2DGOJRGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- George W Vandenberghe *Lynker Technologies at * NOAA/NWS/NCEP/EMC 5830 University Research Ct., Rm. 2141 College Park, MD 20740 ***@***.*** 301-683-3769(work) 3017751547(cell)

mathomp4 · 2024-10-08T12:48:33Z

With MAPL-2.64.4, it runs and passes the previous error stage, but still gives the error.

Logfile: /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/err /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/out

I'll ping @weiyuan-jiang to see if he can see these files and get the error back to us.

weiyuan-jiang · 2024-10-08T13:08:02Z

I saw the error:
"FAIL at line=02767 Base_Base_implementation.F90 "

That means somewhere in the configure file, a non cubed-sphere grid is labeled as cubed-sphere grid. Otherwise, it will not go into that call. (https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/base/Base/Base_Base_implementation.F90#L2630C4-L2633C1)

RatkoVasic-NOAA · 2024-10-08T13:22:24Z

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.8.0/envs/test1/install/modulefiles/Core module load stack-intel/2021.9.0 module load stack-intel-oneapi-mpi/2021.9.0 module load cmake/3.23.1 When I do this I cannot see mapl/2.46.4 I get from module spider Versions: mapl/2.40.3-esmf-8.6.0 mapl/2.46.3-esmf-8.6.1

@GeorgeVandenberghe-NOAA use:

module use /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/Core
module load stack-intel/2021.9.0
module load stack-intel-oneapi-mpi/2021.9.0
module load cmake/3.23.1

module avail mapl

---------------------------------------- /work/noaa/epic/role-epic/spack-stack/hercules/spack-stack-1.6.0/envs/ue-esmf-8.6.1-mapl-2.46.4/install/modulefiles/intel-oneapi-mpi/2021.9.0/intel/2021.9.0 ----------------------------------------
   mapl/2.46.3-esmf-8.6.1    mapl/2.46.4-esmf-8.6.1 (D)

weiyuan-jiang · 2024-10-08T13:43:33Z

With MAPL-2.64.4, it runs and passes the previous error stage, but still gives the error.

Logfile: /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/err /work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_3176372/cpld_bmark_p8_intel/out

Can you compare the configure files that have run successfully?

lipan-NOAA · 2024-10-08T17:47:40Z

@weiyuan-jiang Comparing with the successful case (/work2/noaa/stmp/lipan/stmp/lipan/FV3_RT/rt_2762037/cpld_bmark_p8_intel) using 2.40.3-esmf-8.6.0, I did not see any difference in the model configuration.

ulmononian · 2024-10-15T22:07:37Z

@DusanJovic-NOAA @junwang-noaa absolutely understand that testing is underway, though just wanted to touch base and see if there was any luck w/ mapl/2.46.4 & gocart? i saw @lipan-NOAA mentioned an error persisting w/ 2.46.4 in this comment, but wanted to check if there had been any progress. we are testing the ufs-wm w/ spack-stack/1.8.0 with intel classic compilers right now and want to provide the correct esmf/mapl pair for the ufs-wm. additionally, knowing which mapl/esmf version (and spack-stack version) the WM will move to may help to target development efforts for spack-stack w/ LLVM compilers.

junwang-noaa · 2024-10-16T02:14:51Z

@ulmononian No, the issue in MAPL 2.46.4 is not resolved yet.

junwang-noaa · 2024-10-16T02:15:41Z

@weiyuan-jiang Do you have any clue what might cause the failure?

DusanJovic-NOAA · 2024-10-17T16:15:40Z

I repeated one of the coupled tests that runs GOCART (cpld_control_p8) using MAPL 2.46.4. This is the full err file:
err.txt

Basically the same error as @lipan-NOAA got in his test here (#2406 (comment))

mathomp4 · 2024-10-17T22:59:24Z

I repeated one of the coupled tests that runs GOCART (cpld_control_p8) using MAPL 2.46.4. This is the full err file: err.txt

Basically the same error as @lipan-NOAA got in his test here (#2406 (comment))

That same weird Cap GridComp error:

https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/gridcomps/Cap/MAPL_CapGridComp.F90#L1088

of ESMF_RC_NOT_FOUND.

@DusanJovic-NOAA Can you post the CAP.rc for this run? Maybe if I or @bena-nasa or @weiyuan-jiang can see it, we can see...something. 🤷🏼

And then we see the wrong grid error as well from:

https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/base/Base/Base_Base_implementation.F90#L2767

DusanJovic-NOAA · 2024-10-18T12:52:51Z

I repeated one of the coupled tests that runs GOCART (cpld_control_p8) using MAPL 2.46.4. This is the full err file: err.txt
Basically the same error as @lipan-NOAA got in his test here (#2406 (comment))

That same weird Cap GridComp error:

https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/gridcomps/Cap/MAPL_CapGridComp.F90#L1088

of ESMF_RC_NOT_FOUND.

@DusanJovic-NOAA Can you post the CAP.rc for this run? Maybe if I or @bena-nasa or @weiyuan-jiang can see it, we can see...something. 🤷🏼

And then we see the wrong grid error as well from:

https://github.com/GEOS-ESM/MAPL/blob/3295ceebe7e870aaca2018c12ea1ac82d0628fa5/base/Base/Base_Base_implementation.F90#L2767

Here is CAP.rc: CAP.rc.txt

weiyuan-jiang · 2024-10-18T13:06:22Z

After Ben fixed the regridding error, this error showed up. But the problem is this error should have shown up before the regridding error.

mathomp4 · 2024-10-18T14:53:44Z

Here is CAP.rc: CAP.rc.txt

Well, dang. We know of some ESMF oddities recently with commas and quotes, but that looks boring.

junwang-noaa · 2024-10-21T16:43:08Z

@mathomp4 do you have a fix for the issue in CAP.rc.txt?

mathomp4 · 2024-10-21T17:14:25Z

@mathomp4 do you have a fix for the issue in CAP.rc.txt?

@junwang-noaa I think @weiyuan-jiang is now trying to duplicate the error on hercules. He's trying to add prints into MAPL to track down what is going on.

junwang-noaa · 2024-11-09T00:49:13Z

@lipan-NOAA @DusanJovic-NOAA Please see the new spack-stack Alex installed: JCSDA/spack-stack#1168 (comment)

DusanJovic-NOAA added 3 commits August 15, 2024 11:09

Update .gitmodules and CMakeModules

bfd347d

Remove cmake/FindESMF.cmake and rename esmf target to ESMF::ESMF

c994cb0

Special case for finding FindESMF.cmake on WCOSS2 in non-standard loc…

8157915

…ation

DusanJovic-NOAA marked this pull request as draft August 23, 2024 14:09

DusanJovic-NOAA added 2 commits September 16, 2024 14:08

Update FV3, CDEPS and CMEPS

ec4ec28

Merge remote-tracking branch 'origin/develop' into remove_findesmf

a0997d1

Merge remote-tracking branch 'origin/develop' into remove_findesmf

8219286

mathomp4 mentioned this pull request Oct 7, 2024

GitFlow: Merge 2.46.4 hotfix into main GEOS-ESM/MAPL#3081

Merged

7 tasks

[DRAFT] Remove local copies of FindESMF from all components, update ESMF to 8.6.1 and MAPL to 2.46.3 #2406

Are you sure you want to change the base?

[DRAFT] Remove local copies of FindESMF from all components, update ESMF to 8.6.1 and MAPL to 2.46.3 #2406

Conversation

DusanJovic-NOAA commented Aug 23, 2024 • edited Loading

Commit Queue Requirements:

Description:

Commit Message:

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:

Testing Log:

bbakernoaa commented Sep 13, 2024

DusanJovic-NOAA commented Sep 17, 2024

bbakernoaa commented Sep 18, 2024

DusanJovic-NOAA commented Sep 18, 2024

DusanJovic-NOAA commented Sep 24, 2024

junwang-noaa commented Sep 24, 2024

weiyuan-jiang commented Sep 24, 2024

bena-nasa commented Sep 25, 2024 • edited Loading

junwang-noaa commented Sep 30, 2024

DusanJovic-NOAA commented Sep 30, 2024

junwang-noaa commented Sep 30, 2024

GeorgeVandenberghe-NOAA commented Oct 1, 2024

junwang-noaa commented Oct 1, 2024

GeorgeVandenberghe-NOAA commented Oct 1, 2024 via email

RatkoVasic-NOAA commented Oct 1, 2024

junwang-noaa commented Oct 2, 2024

RatkoVasic-NOAA commented Oct 2, 2024

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

RatkoVasic-NOAA commented Oct 2, 2024

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

BrianCurtis-NOAA commented Oct 2, 2024 • edited Loading

BrianCurtis-NOAA commented Oct 2, 2024

GeorgeVandenberghe-NOAA commented Oct 2, 2024 via email

lipan-NOAA commented Oct 7, 2024

tclune commented Oct 7, 2024

mathomp4 commented Oct 7, 2024

RatkoVasic-NOAA commented Oct 7, 2024

mathomp4 commented Oct 7, 2024

RatkoVasic-NOAA commented Oct 7, 2024

RatkoVasic-NOAA commented Oct 7, 2024 • edited Loading

mathomp4 commented Oct 7, 2024

GeorgeVandenberghe-NOAA commented Oct 7, 2024 via email

RatkoVasic-NOAA commented Oct 7, 2024 • edited Loading

lipan-NOAA commented Oct 7, 2024

GeorgeVandenberghe-NOAA commented Oct 8, 2024 via email

mathomp4 commented Oct 8, 2024

weiyuan-jiang commented Oct 8, 2024

RatkoVasic-NOAA commented Oct 8, 2024

weiyuan-jiang commented Oct 8, 2024

lipan-NOAA commented Oct 8, 2024

ulmononian commented Oct 15, 2024

junwang-noaa commented Oct 16, 2024

junwang-noaa commented Oct 16, 2024

DusanJovic-NOAA commented Oct 17, 2024

mathomp4 commented Oct 17, 2024

DusanJovic-NOAA commented Oct 18, 2024

weiyuan-jiang commented Oct 18, 2024 • edited Loading

mathomp4 commented Oct 18, 2024

junwang-noaa commented Oct 21, 2024

mathomp4 commented Oct 21, 2024

junwang-noaa commented Nov 9, 2024

DusanJovic-NOAA commented Aug 23, 2024 •

edited

Loading

bena-nasa commented Sep 25, 2024 •

edited

Loading

BrianCurtis-NOAA commented Oct 2, 2024 •

edited

Loading

RatkoVasic-NOAA commented Oct 7, 2024 •

edited

Loading

RatkoVasic-NOAA commented Oct 7, 2024 •

edited

Loading

weiyuan-jiang commented Oct 18, 2024 •

edited

Loading