Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Coupling Option of LND (Noah-MP) and ATM (FV3) #171

Merged
merged 59 commits into from
Dec 31, 2024
Merged

Add New Coupling Option of LND (Noah-MP) and ATM (FV3) #171

merged 59 commits into from
Dec 31, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Nov 18, 2024 •
edited
Loading

Description

  • Add a new option for coupling LND (Noah-MP) and ATM (FV3ATM) to the build script app_build.sh. This option can be compiled as follows:

For LND-FV3ATM

cd sorc
./app_build -a=ATML

For LND-DATM

cd sorc
./app_build
  • UFS_UTILS (chgres_cube) is added to the submodules for the cold-start option.
  • The C-test scripts are simplified.
  • Introduce a new python script setup_wflow_env.py to set up the workflow environment in parm.
  • Add new sample scripts config.ATML.[coldstart/warmstart].yaml for ATML. (config.LND.[coldstart/warmstart].yaml for LND-DATM coupling).
  • To run the new LND-ATM coupling (on Hercules):
cd HOMElandda
source versions/run.ver_hercules
module use modulefiles
module load wflow_hercules
conda activate land_da

cd parm

For LND-FV3ATM:

cp config_samples/config.ATML.[coldstart/warmstart].yaml config.yaml
./setup_wflow_env.py
cd ../../exp_case/atml_[coldstart/warmstart]_00
./launch_rocoto_wflow.sh

for LND-DATM:

cp config_samples/config.LND.[coldstart/warmstart].yaml config.yaml
./setup_wflow_env.py
cd ../../exp_case/lnd_[coldstart/warmstart]_00
./launch_rocoto_wflow.sh

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • apply_incr.fd (NOAA-PSL/land-apply_jedi_incr)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • none

Linked PR's and Issues:

Resolve Issues #170 , #162 , and #138

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Hercules
  • CI
    • Completed
  • WE2E
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

chan-hoo added 30 commits October 28, 2024 07:17
@chan-hoo
update hash of ufs-weather-model
2e99d96
@chan-hoo
add atm-land compile option
5a53888
@chan-hoo
fix camke_setting issue
7b177eb
@chan-hoo
change if condition
90d85be
@chan-hoo
add initial templates for ATML
b176f3b
@chan-hoo
make use common templates
5bc07d5
@chan-hoo
merge model_configure templates
fdfdca3
@chan-hoo
fix missing change
f246d75
@chan-hoo
initial setup script
f3f5a21
@chan-hoo
update setup script
a2c4016
@chan-hoo
fix fill_jinja issue on setup script
8f76ff0
@chan-hoo
change launch script to template
dee2a6b
@chan-hoo
fix missing parms in templates
71e2bd1
@chan-hoo
make hpc parm calculated in script
da91a30
@chan-hoo
fix missing change
8d2c285
@chan-hoo
change name ncores
9c32b86
@chan-hoo
add missinog max cores
59c02d2
@chan-hoo
fix format issue in ufs.configure
3c5634e
@chan-hoo
add confgi.atml.yaml
a66ab5b
@chan-hoo
update script to add atml option
155ebfa
@chan-hoo
remove tstub and tpath
82fedbe
@chan-hoo
remove atm_model from config
5d2a7bf
@chan-hoo
fix mismatch in script
3ef00be
@chan-hoo
fix coldstart issue on forecast
c889c2e
@chan-hoo
add ufs_utils for cold start IC
9aed832
@chan-hoo
update module files
57b0ac5
@chan-hoo
add fcst_ic task
02f899b
@chan-hoo
change template for chgres_cube
678bf4c
@chan-hoo
Merge branch 'develop' of https://github.com/chan-hoo/land-DA_workflow …
ade7662 
…into feature/atmland
@chan-hoo
fix namelist issue on chgres_cube
f45f7e5
@chan-hoo chan-hoo requested a review from jkbk2004 November 18, 2024 13:44
This was linked to issues Nov 18, 2024
Need to Add a New Capability Coupling LAND and FV3 ATM models of UFS Weather Model #170
Closed
UFS WM RT data directories mismatch with S3 data #162
Closed
@chan-hoo chan-hoo linked an issue Nov 26, 2024 that may be closed by this pull request
Updated GHCN observation data files #138
Closed
@chan-hoo
Copy link
Collaborator Author

ctest for LND on Hera:

+ ctest
Test project /scratch2/NCEPDEV/naqfc/Chan-hoo.Jeon/landda_test/land-DA_workflow/sorc/build
    Start 1: test_create_ens
1/4 Test #1: test_create_ens ..................   Passed    3.10 sec
    Start 2: test_letkfoi_snowda
2/4 Test #2: test_letkfoi_snowda ..............   Passed   14.03 sec
    Start 3: test_apply_jediincr
3/4 Test #3: test_apply_jediincr ..............   Passed    2.06 sec
    Start 4: test_ufs_datm_land
4/4 Test #4: test_ufs_datm_land ...............   Passed   33.91 sec

100% tests passed, 0 tests failed out of 4

Total Test time (real) =  53.11 sec

@chan-hoo
Copy link
Collaborator Author

On Orion:

+ ctest
Test project /work/noaa/epic/chjeon/landda_test_orion/land-DA_workflow/sorc/build
    Start 1: test_create_ens
1/4 Test #1: test_create_ens ..................   Passed   10.52 sec
    Start 2: test_letkfoi_snowda
2/4 Test #2: test_letkfoi_snowda ..............   Passed   31.29 sec
    Start 3: test_apply_jediincr
3/4 Test #3: test_apply_jediincr ..............   Passed    2.42 sec
    Start 4: test_ufs_datm_land
4/4 Test #4: test_ufs_datm_land ...............   Passed   50.72 sec

100% tests passed, 0 tests failed out of 4

Total Test time (real) =  94.96 sec

@chan-hoo
Copy link
Collaborator Author

On Hercules:

+ ctest
Test project /work/noaa/epic/chjeon/landda_test/land-DA_workflow/sorc/build
    Start 1: test_create_ens
1/4 Test #1: test_create_ens ..................   Passed    9.00 sec
    Start 2: test_letkfoi_snowda
2/4 Test #2: test_letkfoi_snowda ..............   Passed   25.56 sec
    Start 3: test_apply_jediincr
3/4 Test #3: test_apply_jediincr ..............   Passed    1.92 sec
    Start 4: test_ufs_datm_land
4/4 Test #4: test_ufs_datm_land ...............   Passed   35.85 sec

100% tests passed, 0 tests failed out of 4

Total Test time (real) =  72.34 sec

@chan-hoo chan-hoo merged commit 7f806b0 into ufs-community:develop Dec 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chan-hoo @jkbk2004