Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Intel LLVM compilers #879

Open
DavidHuber-NOAA opened this issue Dec 5, 2023 · 15 comments · May be fixed by #996
Open

Upgrade to Intel LLVM compilers #879

DavidHuber-NOAA opened this issue Dec 5, 2023 · 15 comments · May be fixed by #996
Assignees
@GeorgeGayno-NOAA

Comments

@DavidHuber-NOAA
Copy link
Collaborator

DavidHuber-NOAA commented Dec 5, 2023 •
edited by GeorgeGayno-NOAA
Loading

The 'classic' Intel compilers (ifort, icc, and icpc) are now discontinued and the new LLVM compilers (ifx and icx) are the only option starting with version 2024. All supported machines with working versions of the LLVM compilers should be upgraded to the LLVM suite.

Per @junwang-noaa - try to use the 2024 version as the 2023 version has some bugs.
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Dec 5, 2023
Open
8 tasks
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Aug 12, 2024
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 12, 2024
Updates to build emcsfc_snow2mdl with intelLLVM.
8ace80f 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 12, 2024
Updates to build weight_gen using intelLLVM.
8b2e37c 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 13, 2024
Updates to vcoord_gen to build with IntelLLVM.
6b44404 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 13, 2024
Update the ocnice_prep compilation to use intelLLVM.
5e262ce 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 13, 2024
Update chgres and cpld_gridgen builds to use intelLLVM.
28c90a1 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 13, 2024
Update glbevents and global_cycle builds to use
b56fe41 
IntelLLVM.

Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 14, 2024
Update build for sfc_climo_gen and grid_tools.
e87daf5 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 14, 2024
Update build for the orography related codes.
ab25159 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 14, 2024
Update ocean_merge compilation.
3228025 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 14, 2024
Turn on compilation of fvcom_tools.
76c137a 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 14, 2024
Minor source code updates to fre-nctools to eliminate
82bfcd8 
compiler warnings.

Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 19, 2024
@GeorgeGayno-NOAA
Update build module on Orion.
8a50fb0 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 19, 2024
@GeorgeGayno-NOAA
Update Orion build to match UFSWM.
13f8bc0 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 19, 2024
Update hercules build to match UFSWM.
4737e07 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 19, 2024
@GeorgeGayno-NOAA
Update hera build module following the example of the
baf6edd 
UFSWM.

Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 19, 2024
@GeorgeGayno-NOAA
Update build for unit tests.
e23e79c 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 20, 2024
Update fvcom_tools build for IntelLLVM.
97d8e44 
Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 20, 2024
Update main CMakeLists.txt to set 'C' compiler options.
1056ef5 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Copy link
Collaborator

Using 1056ef5, the unit tests were successfully run on Hercules and Hera.

NOTE: Setting CMAKE_C_FLAGS_RELEASE "-O2" (in ./CMakeLists.txt) caused the fre-nctools/tst_create_xgrid unit test to 'seg fault'. For now, I will set CMAKE_C_FLAGS_RELEASE "-O1" for IntelLLVM

GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 22, 2024
Update ubuntu_intel.yaml workflow file to use IntelLLVM.
c10e85a 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA - I want to update the Github workflows to use IntelLLVM. I think I completed part of the update at c10e85a. However, the libraries are built using https://github.com/GeorgeGayno-NOAA/UFS_UTILS/blob/intelLLVM/ci/spack.yaml. Can you or someone on the libraries team assist me with updating spack.yaml?

@GeorgeGayno-NOAA
Copy link
Collaborator

Hash c10e85a was tested on Hercules. All regression tests were run:

  • global_cycle, ice_blend, ocnice_prep and snow2mdl and weight_gen all passed.
  • chgres_cube tests 6, 7, and 11 failed. All others passed.
  • cpld_gridgen - all tests failed.

All failed tests had roundoff differences from their baselines.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 23, 2024
@GeorgeGayno-NOAA
Merge branch 'develop' into intelLLVM
9511885 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Copy link
Collaborator

All regression tests were run on WCOSS2 using 9511885. All tests passed as expected.

@GeorgeGayno-NOAA
Copy link
Collaborator

My preliminary tests show UFS_UTILS is working with the existing spack-stacks.

Will hold off on further work until it is determined whether new versions of spack-stack (that use IntelLLVM) will be implemented.

GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 27, 2024
Update speck build.
56bf5e1 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Aug 28, 2024
@GeorgeGayno-NOAA
Change definitions of CC and FC.
98f840a 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA - I want to update the Github workflows to use IntelLLVM. I think I completed part of the update at c10e85a. However, the libraries are built using https://github.com/GeorgeGayno-NOAA/UFS_UTILS/blob/intelLLVM/ci/spack.yaml. Can you or someone on the libraries team assist me with updating spack.yaml?

I tried updates at 56bf5e1 and 98f840a, but the spack build fails during the compilation of sigio library routine sigio_module.f. I also see numerous warnings concerning compiler options. For example:

warning: unknown warning option '-Wc90-c99-compat'; did you mean '-Wc99-compat'? [-Wunknown-warning-option]

@AlexanderRichert-NOAA
Copy link
Collaborator

No, version 2.3.3 isn't in the JCSDA fork yet. Let me see if I can add that right now...

Merged
@AlexanderRichert-NOAA
Copy link
Collaborator

It should work once JCSDA/spack#480 is merged.

GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 22, 2024
Rename hercules build module so both the new and old
082fb20 
intel compilers may be used.

Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 22, 2024
Add back the intel classic build module for hercules.
9a4ae70 
Fixes ufs-community#879.
@AlexanderRichert-NOAA
Copy link
Collaborator

(Done)

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 22, 2024
@GeorgeGayno-NOAA
Rename orion build module to reflect new compiler.
948331c 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 22, 2024
@GeorgeGayno-NOAA
Add back intel classic build module for orion.
dfb8730 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 23, 2024
@GeorgeGayno-NOAA
Remove sfcio library from spack.yaml as it is not used
a4136eb 
by the unit tests.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Copy link
Collaborator

(Done)

Thanks. Now I am running into the same issue with sfcio v1.4.1. My unit tests no longer use sfcio, so I am removing it from the workflow. But other users will need access to v1.4.2.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 23, 2024
@GeorgeGayno-NOAA
Add diagnostic print to chgres_cube test.
f47f84d 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 23, 2024
@GeorgeGayno-NOAA
Increase error threshold for the chgres/ftst_read_atm_grib2.F90
6c57bf9 
check of pressure.

Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 23, 2024
@GeorgeGayno-NOAA
Rename hera build module as intelllvm.
b2e987b 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 23, 2024
@GeorgeGayno-NOAA
Add back hera intel classic build modules.
ba8d241 
Fixes ufs-community#879.
@AlexanderRichert-NOAA
Copy link
Collaborator

sfcio 1.4.2 is now available under JCSDA Spack.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 24, 2024
@GeorgeGayno-NOAA
Remove some references to intel classic in workflow files.
8ae6efa 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 25, 2024
@GeorgeGayno-NOAA
Add logic to build_all.sh script to default to Intel classic
4c6d932 
if Intel LLVM is not available.

Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 25, 2024
Correct bug in build_all.sh.
addccd3 
Fixex ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 25, 2024
Update grid driver scripts to use intelLLVM and Hercules,
203b2de 
Orion and Hera.

Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 25, 2024
Update the weight_gen utility driver scripts on Hercules,
2d44d8b 
Hera and Orion to default to intelLLVM.

Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 25, 2024
Update the gdas_init utility driver scrip on Hera to use
31c62bd 
intelLLVM.

Fixes ufs-community#879.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 25, 2024
Update the hercules regression test scripts to load the intelLLVM
3fa0aa5 
module.

Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 28, 2024
@GeorgeGayno-NOAA
Update module load in the sfc_climo_gen utility.
1211785 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 31, 2024
@GeorgeGayno-NOAA
Update the intelLLVM version 2024 on Hera.
2324720 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 31, 2024
@GeorgeGayno-NOAA
Update regression test scripts to default to intelLLVM.
adf1650 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 31, 2024
@GeorgeGayno-NOAA
Modify the "-check all" compiler option for intelLLVM as
f1532e5 
on Hera it caused a compilation error when choosing
'debug' mode.

Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 31, 2024
@GeorgeGayno-NOAA
Update Orion regresson test driver scripts to default to
7efdbed 
intel LLVM.

Fixes ufs-community#879.
@GeorgeGayno-NOAA GeorgeGayno-NOAA linked a pull request Nov 4, 2024 that will close this issue
Open
10 tasks
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 8, 2024
@GeorgeGayno-NOAA
Merge branch 'develop' into intelLLVM
2acab86 
Fixes ufs-community#879.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 12, 2024
@GeorgeGayno-NOAA
Merge branch 'develop' into intelLLVM
c868685 
Fixes ufs-community#879.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port to Intel LLVM on Hera, Orion and Hercules GeorgeGayno-NOAA/UFS_UTILS
3 participants
@GeorgeGayno-NOAA @DavidHuber-NOAA @AlexanderRichert-NOAA