Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier linting to project #253

Open
h1divp opened this issue Sep 6, 2024 · 7 comments
Open

Add Prettier linting to project #253

h1divp opened this issue Sep 6, 2024 · 7 comments
Assignees
Labels
Documentation Improvements or additions to documentation Easy A simple problem or change that needs to be fixed or made. Help wanted Someone needs to work on this Workflow Improvements to development quality of life

Comments

@h1divp
Copy link
Collaborator

h1divp commented Sep 6, 2024

Linting (which automatically formats saved files to have correct whitespacing, semicolons at the end of line, etc) is currently implemented in our Github actions pipline (automated testing system) but I think it would be beneficial to add Prettier support so that the linter runs after people save files in their IDE or text editor. Prettier is quite popular, and I also think we should recommend it in the documentation. That being said, even if we do add support, using prettier should still be completely optional, and just for those who would like to use it.

Note that this will need to be set up separately for both the front-end and back-end.

@h1divp h1divp added Workflow Improvements to development quality of life Documentation Improvements or additions to documentation labels Sep 6, 2024
@EdleyF
Copy link

EdleyF commented Sep 6, 2024

Can I tackle this issue?

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 7, 2024

I left an important comment considering the Prettier implementation here
I also didn't understand that Prettier isn't exactly a linter, but rather a code formatter, before creating this issue, my apologies.

@AlexanderWangY
Copy link
Collaborator

@h1divp any update on this? Should we close?

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 9, 2024

Idk the person currently assigned hasn't responded to my last message, or otherwise I haven't heard from them

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 9, 2024

I wouldn't close it but rather reassign if no progress is made soon

@h1divp h1divp added the Easy A simple problem or change that needs to be fixed or made. label Sep 17, 2024
@dyland88 dyland88 added the Help wanted Someone needs to work on this label Oct 1, 2024
@aleguy02
Copy link
Contributor

aleguy02 commented Nov 5, 2024

Can I be added to this issue?

@aleguy02
Copy link
Contributor

aleguy02 commented Nov 21, 2024

Hey, could I get clarification on what we are aiming for? Do we want to support prettier on any IDE or just VS Code? I ask because I have an idea of how to implement it if we were to just support VS Code but if we want to support more I can look into it.

Edit: I mean as far as formatting on save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Easy A simple problem or change that needs to be fixed or made. Help wanted Someone needs to work on this Workflow Improvements to development quality of life
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants