Skip to content

Commit 2e934b1

Browse files
Steve RhoadesSteve Rhoades
Steve Rhoades
authored and
Steve Rhoades
committed
Refactor DynamicFormControlListDataProvider to a generic interface for consistency
1 parent b9fbdf3 commit 2e934b1

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

projects/ng-dynamic-forms/core/src/lib/model/misc/dynamic-form-control-data.model.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ export interface DynamicFormControlDataConfig {
1111
service: any;
1212
}
1313

14-
export interface DynamicFormControlListDataProvider {
15-
fetchList(value: string): Observable<any[]>;
14+
export interface DynamicFormControlListDataProvider<T> {
15+
fetchList(value: string): Observable<T[]>;
1616
}
1717

1818
export interface DynamicFormControlOptionDataProvider<T> {

projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import {DynamicFormGroupModel} from '../model/form-group/dynamic-form-group.mode
1515
import {DynamicFormOptionConfig} from '../model/dynamic-option-control.model';
1616

1717
@Injectable()
18-
class TestProvider implements DynamicFormControlListDataProvider, DynamicFormControlOptionDataProvider<string> {
19-
fetchList(value: string): Observable<any[]> {
18+
class TestProvider implements DynamicFormControlListDataProvider<string>, DynamicFormControlOptionDataProvider<string> {
19+
fetchList(value: string): Observable<string[]> {
2020
return of(['test']);
2121
}
2222

projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-data.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class DynamicFormDataService {
4545
});
4646
}
4747

48-
isListProvider(provider: DynamicFormControlListDataProvider): boolean {
48+
isListProvider(provider: DynamicFormControlListDataProvider<any>): boolean {
4949
return provider.fetchList !== undefined;
5050
}
5151

0 commit comments

Comments
 (0)