Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add informative comment on @NullUnmarked injections #99

Closed
wants to merge 66 commits into from
Closed

Add informative comment on @NullUnmarked injections #99

wants to merge 66 commits into from

Conversation

nimakarimipour
Copy link
Member

This PR is built upon #95

This PR resolves #97 by adding informative comment on @NullUnmarked injections.

Each comment has the format below:

// local for errors within the scope of the annotation, //non-local for errors outside annotation scope but within the same module, and //dependent module for errors in dependent modules.

To activate comment generation on NullUnmarked injection, flag acg must be passed to Annotator. We can also add a prefix to all generated comments via flag: cprefix.

-acg, --acitave-comment-generation
-cprefix, --comment-prefix (optional)

Or via passing a json file.

"COMMENT": {
     "ACTIVATION": true,
     "PREFIX": "prefix"
}

@nimakarimipour
resolve #71
44afe23
@nimakarimipour
resolve issue-79
b39d72c
@nimakarimipour
update
d820b07
@nimakarimipour
add unit tests
6a5b075
@nimakarimipour
Merge branch 'nimak/issue-79' into nimak/add-supresswarnings
919d2ee
@nimakarimipour
more renames
38a79a6
@nimakarimipour
Merge branch 'nimak/nullaway_update' into nimak/add-supresswarnings
b836928
@nimakarimipour
merge with nimak/nullaway_update
8af3ce6
@nimakarimipour
initial implementation
3f1009b
@nimakarimipour
update
39958a4
@nimakarimipour
update nullaway version
af9fd46
@nimakarimipour
update field region
74b7b3b
@nimakarimipour
merge with nimak/nullaway_update
690763d
@nimakarimipour
remove wrong check
aa4ebc6
@nimakarimipour
update region structure
440608d
@nimakarimipour
cleanup
d218d29
@nimakarimipour
update adapters in config
c4e9d89
@nimakarimipour
update CI
55cd6ae
@nimakarimipour
add adapters
7ee9a7b
@nimakarimipour
add javadoc
28c52a1
@nimakarimipour
remove unwanted test
898be2f
@nimakarimipour
keep metadata untouched
605171e
@nimakarimipour
fix bug
a0db707
@nimakarimipour
merge with nimak/nullaway_update
cb259a3
@nimakarimipour
Merge branch 'master' into nimak/add-supresswarnings
b0b584a
@nimakarimipour
fix conflict
aecff9f
@nimakarimipour
make adopter initialize lazily
adeaf9a
@nimakarimipour
fix adapter
035053f
@nimakarimipour
Merge branch 'master' into nimak/nullaway_update
6a2898e
@nimakarimipour
resolve conflicts
eba2200
@nimakarimipour
change to calleeMember
851f8eb
@nimakarimipour
change Error to Fix
2ae2b00
@nimakarimipour
change Error to TrackerNode
204ec6b
@nimakarimipour
Merge branch 'nimak/nullaway_update' into nimak/add-supresswarnings
c9c1ca1
@nimakarimipour
add preconditions in deserializations
b21407e
@nimakarimipour
extract output file name into a constant
caff1d3
@nimakarimipour
rename to usedClass and usedMember
bc2ad4e
@nimakarimipour
add preconditions for deserializations
94d4efe
@nimakarimipour
extract output file name into a constant
2db1d9a
@nimakarimipour
rename to usedClass and usedMember
e86efcd
@nimakarimipour
update header in unit tests
606de6e
@nimakarimipour
erge branch 'nimak/nullaway_update' into nimak/add-supresswarnings
a89a281
@nimakarimipour
Merge branch 'nimak/add-supresswarnings' into nimak/issue-91
50cd17d
@nimakarimipour
rename to compareByMember
69e46e4
@nimakarimipour
Merge branch 'nimak/nullaway_update' into nimak/issue-91
f7337b4
@nimakarimipour
finish comment addition on NullUnmarked injections
5a4aa86
@nimakarimipour
add config flag
7f5c21e
@nimakarimipour nimakarimipour self-assigned this Nov 20, 2022
@nimakarimipour nimakarimipour linked an issue Nov 20, 2022 that may be closed by this pull request
Add informative comment on @NullUnmarked injections #97
Open
@nimakarimipour nimakarimipour added the enhancement New feature or request label Jan 2, 2023
@nimakarimipour
Copy link
Member Author

@msridhar @lazaroclapp I am converting this to draft for now, will get back to it if we wanted to have this feature.

@nimakarimipour nimakarimipour marked this pull request as draft February 6, 2023 02:47
@nimakarimipour
Copy link
Member Author

@msridhar @lazaroclapp I am closing this one as I don't think we have any plans for now to bring this feature back. Also the branch is too old to revive. Please let me know if you would like to discuss this further, thank you.

@nimakarimipour nimakarimipour deleted the nimak/issue-91 branch February 24, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar Awaiting requested review from msridhar

@lazaroclapp lazaroclapp Awaiting requested review from lazaroclapp

Assignees

@nimakarimipour nimakarimipour

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add informative comment on @NullUnmarked injections
1 participant
@nimakarimipour