Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Excel dependency #7

Closed
wants to merge 5 commits into from
Closed

Update Excel dependency #7

wants to merge 5 commits into from

Conversation

dan-knight
Copy link
Collaborator

@dan-knight dan-knight commented Jan 11, 2025

gData no longer supports Excel format as of v3.x.x. The readxl package appears to be the new standard. Though it is a part of Tidyverse, this change imports it alone. "readxl has no external dependencies", so importing the package separately from Tidyverse will be extremely minimal.

Some extra checks were required for the output to be consistent with previous gData implementation. But, this should now integrate seamlessly with any existing package functionality and external code which uses the affected functions.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added the changes included in this pull request to NEWS under the next release version or unreleased, and updated the date.

  • I have updated the version number in metadata.yaml and DESCRIPTION.

  • Both R CMD build and R CMD check run successfully.

@dan-knight
Copy link
Collaborator Author

Closing this as we're taking a different approach. readxl depends on tibble from Tidyverse. Lab policy is to avoid Tidyverse dependencies.

@dan-knight dan-knight closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants