Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up r-lib R CMD check action #6

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Set up r-lib R CMD check action #6

merged 10 commits into from
Jan 21, 2025

Conversation

dan-knight
Copy link
Collaborator

This is a template for UCLA-CDS R package developers to create a github pull request template. Things should be adjusted for individual package including:

  1. additional checklist items sepecific to the package
  2. a description of how testing is expected to be done
  3. a template list or table for testing results
  4. additional notes wrapped in <!--- ---> (or <!-- --> for inline comments) that help PR submitters to fill in.
  5. delete this block of instructional text.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added the changes included in this pull request to NEWS under the next release version or unreleased, and updated the date.

  • I have updated the version number in metadata.yaml and DESCRIPTION.

  • Both R CMD build and R CMD check run successfully.

Closes #...

Testing Results

Case 1

input code
output

Case 2

input code
output

WuSelina
WuSelina previously approved these changes Jan 21, 2025
@dan-knight dan-knight merged commit 0f6e876 into main Jan 21, 2025
6 checks passed
@dan-knight dan-knight deleted the danknight-r-check branch January 21, 2025 23:07
Copy link
Contributor

@WuSelina WuSelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants