Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with plotting.stage_histogram #7

Open
raghav90 opened this issue Jun 2, 2022 · 2 comments
Open

Issue with plotting.stage_histogram #7

raghav90 opened this issue Jun 2, 2022 · 2 comments

Comments

@raghav90
Copy link

raghav90 commented Jun 2, 2022

I think the "stage_histogram" function has a minor bug. For a given class, the sum of its fractions across the assigned stages exceeds 1. I think this can be addressed by fixing the input "bins" parameter when calling the "ax.hist" function.

@noxtoby
Copy link
Member

noxtoby commented Jun 6, 2022

Thanks. Does this also happen in the kde_ebm package? It's more up to date than this one

@raghav90
Copy link
Author

raghav90 commented Jun 7, 2022

Haven't tried it yet but I suspect it may happen there too because the issue seems to be with the function "ax.hist" (and how it behaves when the "bins" parameter is an integer). I set bins to np.arange(max_stage+2) and it works fine at my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants