Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins symlink #61

Open
lilawren opened this issue Jul 5, 2016 · 2 comments
Open

Jenkins symlink #61

lilawren opened this issue Jul 5, 2016 · 2 comments
Assignees
Milestone

Comments

@lilawren
Copy link
Collaborator

lilawren commented Jul 5, 2016

Need a better solution than the symlink fix for the unit testing server.

@nickrsan
Copy link
Member

nickrsan commented Jul 7, 2016

OK, so here's my plan for fixing this:

  1. Change the spreadsheets that provide the input regions to remove {{BASE_DIR}}
  2. Remove the code that processes {{BASE_DIR}} to the actual BASE_DIR variable
  3. Add a function with the @Property decorator tho handle setting and getting the value for each of the major attributes
  4. Add private variables for each attribute that store the real values, while continuing to access the value through the current names. The real names will be composed by the function by combining the base_dir and the remaining portion of the path from the private variable. The setter will check if the set path is absolute. If it is, and the first part matches BASE_DIR, it will strip off BASE_DIR from the front and store the rest in the private attribute (thus allowing other data outside of BASE_DIR to be used, although that should be frowned on during development)

@nickrsan nickrsan added this to the final_model milestone Jul 7, 2016
nickrsan added a commit that referenced this issue Jul 7, 2016
…Property tags. Functions are there - now just need copy and paste and some migrations, as well as to translate this to some of the other models.
@nickrsan
Copy link
Member

nickrsan commented Jul 7, 2016

@lilawren you might be interested in the implementation of this fix - check out the models code for regions - the first few methods handle this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants