Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does fromDoubleWithFixedWidth work? #90

Open
shunshou opened this issue Mar 24, 2017 · 3 comments
Open

Does fromDoubleWithFixedWidth work? #90

shunshou opened this issue Mar 24, 2017 · 3 comments

Comments

@shunshou
Copy link
Member

@chick See chipsalliance/chisel#558
I'm using fromDoubleWithFixedWidth, so if it's getting width = 26 instead of width = 28 for the constants, it implies this thing didn't work... I have no idea why... (unless Chisel also doesn't width pad in reality... despite supporting the construct).

Can you please look into this for me?

I'm just running into so many problems that I can't get any hardware done.

@chick
Copy link
Contributor

chick commented Mar 24, 2017

@shunshou I will look at this right now

@chick
Copy link
Contributor

chick commented Mar 28, 2017

@shunshou You were right, this was the source of the Borked problem. I just got distracted by the OneHotMux stuff. There may still be issues there but fixing this seems to have fixed the Borked example. I have submitted a PR chipsalliance/chisel#564.

@shunshou
Copy link
Member Author

@chick this is one source. Theoretically, I shouldn't have needed to specify width at all and Mux1H should've figured it out. I tried the WithFixedWidth thing in the hopes that it would fix the issue, but it didn't... hence the discovery that this was an issue.

Thanks for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants