Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension height grows incorrectly with finger width #14

Open
fanoplane opened this issue Jul 5, 2020 · 0 comments
Open

Extension height grows incorrectly with finger width #14

fanoplane opened this issue Jul 5, 2020 · 0 comments

Comments

@fanoplane
Copy link

The line referenced below should likely be modified to:

d_m1_yb = od_yc - m1_h//2

One of the requirements for top/bottom extension height is to maintain proper line-end spacing for m1. As written in the existing code, ExtInfo d_m1_y claims d_m1_yt extends roughly m1_h//2 beyond od_yt (assuming m1_h is close to od_h), even though the drain m1 is not actually drawn this way based on get_laygo_conn_yloc_info(). Without suggested modification, for fingers with large w, d_m1_yt causes the extension to grow, roughly proportional to the increase in w, when it should not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant