Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImanageManager doesn't load new images #928

Open
jumbosushi opened this issue May 3, 2019 · 0 comments
Open

ImanageManager doesn't load new images #928

jumbosushi opened this issue May 3, 2019 · 0 comments

Comments

@jumbosushi
Copy link
Contributor

jumbosushi commented May 3, 2019

What behavior were you expecting?

When I scroll toward the bottom of the images inside ImageManager (aka Image Modal), it should request new images & reload UI

What actually happened?

While there is a new request happening, it's now updating the UI. It is stuck with "Loading ..." then keep making requests

load_error

Steps to reproduce

  1. Open new article editor: https://www.ubyssey.ca/admin/articles/new/
  2. Click on Featured Image tab
  3. Click on "Select Image" button
  4. Within the ImageManager modal, scroll all the way down

What was your environment like?

Chrome on Ubuntu 16.04

Ideas

The main logic is in modals/ImageManager/index.js. The component seems to correctly detect & fetch new images, but not updating the UI. I suspect it's the this.props.images not being properly updated

Check out this line to see how images are being rendered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant